Skip to content

Conversation

lsongsuse
Copy link
Contributor

Users must create the secret under Storage → Secrets → Registry:

Screenshot 2025-09-16 at 5 24 11 PM

Newly created secrets in the same namespace as the Registry configuration will appear in the Authentication dropdown.

Screenshot 2025-09-16 at 5 26 42 PM

Copy link
Contributor

@xingzhang-suse xingzhang-suse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the unchanged lines

if (!this.value.status){
this.value.status = {
conditions: [],
};
}

Is this block used anywhere?

So the main logic change is for the filter of docker secrets under the specific namespace instead of display all kinds of secret in the dropdown, right?
Otherwise, it is good to be merged.

@lsongsuse
Copy link
Contributor Author

Regarding the unchanged lines

if (!this.value.status){
this.value.status = {
conditions: [],
};
}

I removed this code block since it was only used to initialize the "status" field for newly created Registry. This initialization is no longer needed.

Is this block used anywhere?
So the main logic change is for the filter of docker secrets under the specific namespace instead of display all kinds of secret in the dropdown, right? Otherwise, it is good to be merged.

Yes, the main logic change is filtering the secrects so that only docker registry secrects within the same namespace are shown in the dropdown.

@xingzhang-suse
Copy link
Contributor

LGTM

@xingzhang-suse xingzhang-suse merged commit 0b6774b into neuvector:main Sep 17, 2025
1 check passed
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (fb8f8b2) to head (f53c38c).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #156   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants