Skip to content

Feat: enable the free-typing for "Repositories to scan" selector #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2025
Merged

Feat: enable the free-typing for "Repositories to scan" selector #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d60f5a9
Feat: enable the free-typing for "Repositories to scan" selector
lsongsuse Aug 15, 2025
ead00ca
Feat: enable the free-typing for "Repositories to scan" selector
lsongsuse Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/sbombastic-image-vulnerability-scanner/constants/scan-interval-options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export const REGISTRY_TYPE = {
}

export const REGISTRY_DEFAULT_URI = {
DOCKERHUB: "https://registry.hub.docker.com"
DOCKERHUB: "index.docker.io"
};

export const REGISTRY_TYPE_OPTIONS: {label: string; value: string }[] = [
Expand Down
22 changes: 12 additions & 10 deletions pkg/sbombastic-image-vulnerability-scanner/edit/sbombastic.rancher.io.registry.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
import CreateEditView from '@shell/mixins/create-edit-view';
import Footer from '@shell/components/form/Footer';
import { LabeledInput } from '@components/Form/LabeledInput';
import { RadioGroup } from '@components/Form/Radio';
import NameNsDescription from '@shell/components/form/NameNsDescription';
import CruResource from '@shell/components/CruResource';
import SelectOrCreateAuthSecret from '@shell/components/form/SelectOrCreateAuthSecret';
Expand All @@ -21,7 +20,6 @@ export default {

components: {
Footer,
RadioGroup,
LabeledInput,
NameNsDescription,
CruResource,
Expand Down Expand Up @@ -54,11 +52,6 @@ export default {
},

computed: {
namespace(){
console.log('this.value.spec.type:',this.value.spec.type);
return this.value.spec.type === 'ecr'?"kube-system":""
},

inStore() {
return this.$store.getters['currentProduct']?.inStore || MANAGEMENT;
},
Expand Down Expand Up @@ -163,16 +156,25 @@ export default {
<div class="row">
<div class="col span-6" >
<LabeledSelect
data-testid="registry-scanning-repository-names"
v-model:value="value.spec.repositories"
:options="value.spec.repositories"
:taggable="true"
:searchable="true"
:push-tags="true"
:close-on-select="false"
:mode="mode"
:multiple="true"
:label="t('imageScanner.registries.configuration.cru.scan.repoName')"
:placeholder="t('imageScanner.registries.configuration.cru.scan.placeholder')"
:label="t('imageScanner.registries.configuration.cru.scan.type')"
:options="value.spec.repositories"
:disabled="mode==='view'"
@update:value="update"
/>
</div>
<div class="col span-3">
<LabeledSelect
v-model:value="value.spec.scanInterval"
data-testid="registry-scan-interval-select"
data-testid="registry-scanning-interval-select"
:options = "SCAN_INTERVAL_OPTIONS"
option-key="value"
option-label="label"
Expand Down
4 changes: 2 additions & 2 deletions pkg/sbombastic-image-vulnerability-scanner/l10n/en-us.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ imageScanner:
label: Authentication
scan:
label: Scanning
type: Repositories to scan
placeholder: Type and press Enter ...
repoName: Repositories to scan
placeholder: Leave empty to scan all. Type and press Enter to add repositories.
schedule:
label: Scan Interval
scan: Start Scan
Expand Down