Fix control button basic functionality with upcoming footer tweaks#2192
Closed
marcustyphoon wants to merge 4 commits intonew-xkit:masterfrom
Closed
Fix control button basic functionality with upcoming footer tweaks#2192marcustyphoon wants to merge 4 commits intonew-xkit:masterfrom
marcustyphoon wants to merge 4 commits intonew-xkit:masterfrom
Conversation
Author
|
I no longer see the code this was intended to address in the Tumblr frontend, so I guess it's not upcoming after all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upcoming tweaks to the post footer may result in our "find the edit button" code to determine whether a post is editable breaking, and may not have any CSS class on some footer button elements that we currently try to copy classes from.
This preserves the basic functionality of adding our own control buttons correctly if these tweaks occur (though it does not fix any layout breakage; we could of course do so in the future).
Specifically, this detects whether a post is editable in react mode using our react
post_propsutility, and makes sure we don't add the css class "undefined" when we don't detect a css class to copy.These are xkit.js changes, which for this currently undeployed 7.10 branch are all that is needed. Deploying this to the live 7.9.2 branch, if I recall correctly, is an xkit patches change, so we will need to PR a change targeting that branch which copy-pastes xkit patches 7.4.24 from this. I think. Probably.
The maintenence state of this codebase is fine.