Skip to content

Conversation

desrosj
Copy link
Member

@desrosj desrosj commented Aug 11, 2025

Proposed changes

This makes the following change to the make-pot command:

  • explicitly pass --domain: The default value for --domain is the project slug when Text Domain is not specified in the main plugin or theme file. Explicitly passing the text domain avoids the scenario where someone checks the repository out in a folder with a custom name.

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Visual

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

The default value for `--domain` is the project slug when `Text Domain` is not specified in the main plugin or theme file. Explicitly passing the text domain avoids the scenario where someone checks the repository out in a folder with a custom name.

Also adds `vendor` and `node_modules` to the `--exclude` flag.
@desrosj desrosj self-assigned this Aug 11, 2025
@Copilot Copilot AI review requested due to automatic review settings August 11, 2025 17:21
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the internationalization build process by explicitly passing the text domain to the make-pot command and expanding the excluded directories. The changes ensure consistent POT file generation regardless of the repository folder name and prevent unnecessary scanning of dependency directories.

  • Explicitly passes --domain=wp-module-deactivation to avoid relying on folder name defaults
  • Adds vendor and node_modules to the exclude list for the POT generation process

Copy link
Contributor

github-actions bot commented Aug 11, 2025

These are excluded by default in `make-pot`.
@wpscholar
Copy link
Member

@desrosj It looks like the workflow wasn't able to set up PHP. We can merge this PR, but we should also figure out the workflow issue.

@desrosj
Copy link
Member Author

desrosj commented Aug 14, 2025

@desrosj It looks like the workflow wasn't able to set up PHP. We can merge this PR, but we should also figure out the workflow issue.

That appears to have been a service-level incident on the GH platform. Re-ran the workflows and PHP was configured correctly, but tests still fail due to unrelated reasons.

@desrosj desrosj merged commit 6c39647 into main Aug 14, 2025
16 of 29 checks passed
@desrosj desrosj deleted the make-pot-command-improvements branch August 14, 2025 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants