Skip to content

Update router logic #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from
Open

Update router logic #779

wants to merge 5 commits into from

Conversation

abhijitb
Copy link
Contributor

Proposed changes

This PR makes the following changes :-

  • Prevent direct access to steps without required data
  • Validate data on component mount
  • Validation on route changes

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

abhijitb added 4 commits June 21, 2025 06:33
@abhijitb
update router logic
d3b83b1 
- Prevent direct access to steps without required data
- Validate data on component mount
- Validation on route changes
@abhijitb
Update MigrationStep.js
adcdded 
the prepareMigration() function was being used before being declared
@abhijitb
lint fixes
4ff604b
@abhijitb
lint fixes 2
120201a
@abhijitb abhijitb requested a review from wpalani June 21, 2025 01:24
Base automatically changed from update/unified-ui to trunk July 2, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpalani wpalani Awaiting requested review from wpalani

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abhijitb