Skip to content

set nfd_migrate_site to false #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

geckod22
Copy link
Contributor

Proposed changes

This PR aim to set the nfd_migration_site option to false once onboarding module run the first migration url step. This PR need to go with newfold-labs/wp-module-migration#158 that manage the dynamic sso onborading redirect for migration based on brand.

A customer start a Website Transfer from MFE, the option nfd_migration_site is set to true, then by sso url magic link the customer is redirected to the onboarding page for migration process. The migration module hooks on the sso success redirect and will dinamically set the url depending on the brand. Once onboarding start the migration process first step the option is set to false.

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Visual

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link
Contributor

github-actions bot commented Jul 29, 2025

Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! @geckod22 moving this to QA.

@arunshenoy99 arunshenoy99 added the QA This PR is in QA label Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA This PR is in QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants