Upgrade and standardize Node.js setup #834
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves a peer dependency conflict for `@wordpress/element`.
This standardizes the Node.js setup by: - Upgrading Node.js version to 22.x. - Removing the `v` from the version in `.nvmrc` - Added `engines` to the `package.json` file. - Ensures the same version is used consistently in GitHub Actions workflows.
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the Node.js environment from version 16 to version 22.x (LTS) and standardizes the Node.js setup across the project. The upgrade aligns with the active LTS version and includes proper version constraints to ensure consistency across development and CI environments.
- Updates Node.js to version 22.11.0 and npm to 10.9.0
- Standardizes version management through .nvmrc and package.json engines field
- Updates GitHub Actions workflow to use the .nvmrc file for consistent Node.js versioning
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Adds engines field with Node.js and npm version constraints, updates UI component library dependency |
| .nvmrc | Updates Node.js version from v16 to 22 and removes version prefix |
| .github/workflows/lint-check-spa.yml | Updates workflow to use .nvmrc file instead of hardcoded Node.js version |
| @@ -37,7 +41,7 @@ | |||
| "dependencies": { | |||
| "@heroicons/react": "^2.2.0", | |||
| "@newfold/js-utility-ui-analytics": "^1.4.0", | |||
| "@newfold/ui-component-library": "^1.3.0", | |||
| "@newfold/ui-component-library": "^2.0.0", | |||
There was a problem hiding this comment.
The UI component library is being upgraded from ^1.3.0 to ^2.0.0, which represents a major version change that could introduce breaking changes. This should be documented in the PR description or tested thoroughly to ensure compatibility.
Copilot uses AI. Check for mistakes.
girish-lokapure
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Note: This branch was created off of #833. That should be discussed and merged before this PR.
This upgrades Node.js to version 22.x, the active LTS version. Version
22.11.0is used as the minimum required version since it represents the release that transitioned the version from current to LTS status. The version ofnpmused (10.9.0) is the version bundled with22.11.0The GitHub Action workflows have been updated to ensure the desired version is used for testing and releasing.
Other changes
vhas been removed from the version in the.nvmrcfile, which is best practice.nodeandnpmare now defined in theenginesfield of thepackage.jsonfile.This addresses PRESS0-2908, PRESS0-2909, PRESS0-291-, PRESS0-2911.
Type of Change
Production
Development
Visual
Checklist
Further comments