Skip to content

Conversation

circlecube
Copy link
Member

Proposed changes

This module is loading assets as:
plugin//vendor/newfold-labs/wp-module-onboarding/...

While the files load that way, this will fix the double // in the path so assets are located in the same path when looking at them all:

Screenshot 2025-07-30 at 7 35 59 AM

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Visual

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube requested a review from wpalani July 30, 2025 12:42
@circlecube circlecube self-assigned this Jul 30, 2025
Copy link
Contributor

@circlecube circlecube merged commit 7a742f2 into trunk Aug 12, 2025
13 of 16 checks passed
@circlecube circlecube deleted the fix/assets-path branch August 12, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants