Skip to content

Implement wp-module-link-tracker features across different URLs #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

crodriguezbrito
Copy link
Contributor

Proposed changes

The following PR will implement the link tracker features across different urls

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Visual

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@crodriguezbrito crodriguezbrito requested a review from a team as a code owner July 23, 2025 14:44
@crodriguezbrito crodriguezbrito self-assigned this Jul 23, 2025
@crodriguezbrito crodriguezbrito marked this pull request as draft July 23, 2025 14:44
Copy link
Contributor

github-actions bot commented Jul 24, 2025

@crodriguezbrito crodriguezbrito marked this pull request as ready for review July 25, 2025 06:36
arunshenoy99
arunshenoy99 previously approved these changes Jul 25, 2025
Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Moving to QA

arunshenoy99
arunshenoy99 previously approved these changes Jul 25, 2025
… URLs generated in PHP and return the default URL if the module is not available.
@crodriguezbrito crodriguezbrito requested review from a team August 6, 2025 08:27
Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for QA to confirm.

@crodriguezbrito @circlecube - @CommitStorm is currently testing this. I’ve merged the other PR's that were already tested and fall under our team’s scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants