-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Ghe integration #21929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Ghe integration #21929
Conversation
|
Hi @cbehera-newrelic 👋 Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days. Please ensure the propsed changes look good by building it first in your local environment. Refer to this contribution guide to get the site up and running in your local. If you really require a preview url, reach out to one of the writers and they will generate one for you. |
|
netlify build |
1 similar comment
|
netlify build |
🚀 Netlify Preview Building!If the build is successful, the preview for this pull request will be available at the following URL (usually takes 10-20 minutes): |
|
|
||
| **Prerequisites** | ||
|
|
||
| * Login to your GitHub Enterprise account you plan to integrate with New Relic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * Login to your GitHub Enterprise account you plan to integrate with New Relic. | |
| * Login to the GitHub Enterprise account you plan to integrate with New Relic. |
|
|
||
| **Prerequisites** | ||
|
|
||
| * Login to your GitHub Enterprise account you plan to integrate with New Relic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is signing in a prerequisite?
| * Docker environment to run the collector service within your GHE network. | ||
|
|
||
|
|
||
| **Architecture overview** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better to show this as a diagram?
vpayyapilly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix and resubmit
|
|
||
| 1. **Create and configure a GitHub app**: In your GHE instance, navigate to **Settings → Developer Settings → GitHub Apps → New GitHub App**. | ||
|
|
||
| 1. **Configure Permissions**: Set the specific permissions required for the app to perform real-time and initial data syncs. A separate document outlining the required permissions will be provided. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provided? Wont it be on the Docs site? Why cant we link to it?
| 1. **Create and configure a GitHub app**: In your GHE instance, navigate to **Settings → Developer Settings → GitHub Apps → New GitHub App**. | ||
|
|
||
| 1. **Configure Permissions**: Set the specific permissions required for the app to perform real-time and initial data syncs. A separate document outlining the required permissions will be provided. | ||
| 2. **Set Up Webhooks**: Configure the Webhook URL (which we will provide) and create a custom Event Secret for secure communication. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where will they find it?
| <tr> | ||
| <td>`API_KEY`</td> | ||
| <td>New Relic</td> | ||
| <td>Generate an API key from the New Relic dashboard.</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldnt it be better to have deep links here?
| We will provide a sample Docker Compose file that automates the download and deployment of the service. | ||
|
|
||
| 1. Download the provided Docker Compose file. | ||
| 2. Configure the environment variables from step 2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which step 2?
|
|
||
| **Option B: Direct Docker image run** | ||
|
|
||
| You can download the Docker image directly from our Docker App registry and run it using your organization's preferred CI/CD pipeline or deployment method. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link to Docker app library?
| 4. **Access the New Relic UI**: | ||
|
|
||
| 1. Once the collector service is running and the GitHub App is installed on your GHE organization(s), the corresponding GHE organizations will appear in the New Relic UI. | ||
| 2. Click **First time sync** to start the initial data synchronization. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
, ,
|
|
||
| 5. On the **GitHub Enterprise integration** screen: | ||
|
|
||
| - Click **Go to Teams** to view the imported teams information on [Teams](/docs/service-architecture-intelligence/teams/teams). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go through all your instructions and align them to , , format
|
Warning An image has been added to Image files must be in |
|
netlify build |
1 similar comment
|
netlify build |
|
netlify build |
|
netlify build |
|
netlify build |
| * `workflow_job` | ||
|
|
||
| <Callout variant="tip"> | ||
| **Security best practice**: Only enable the minimum permissions required for your integration needs. This reduces security exposure and follows the principle of least privilege access. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| **Security best practice**: Only enable the minimum permissions required for your integration needs. This reduces security exposure and follows the principle of least privilege access. | |
| **Security best practice**: To reduce security exposure, follow the principle of least privilege access and only enable the minimum permissions required for your integration needs. |
|
|
||
| ### Generate and convert keys | ||
|
|
||
| 1. Upon creation, the app will generate a unique App ID and a Private Key file (.pem format). Save these securely as they will be needed for the collector service configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 1. Upon creation, the app will generate a unique App ID and a Private Key file (.pem format). Save these securely as they will be needed for the collector service configuration. | |
| 1. Upon creation, the app generates a unique App ID and a Private Key file (.pem format). Save these securely as you need them for the collector service configuration. |
|
|
||
| 1. Navigate to your GitHub Enterprise instance. | ||
| 2. Go to **Settings** → **Developer Settings** → **GitHub Apps**. | ||
| 3. Find the GitHub App you created in step 1 and click on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Click the Github App you created in step 1.
Should "click" here be "select"?
| 1. Navigate to your GitHub Enterprise instance. | ||
| 2. Go to **Settings** → **Developer Settings** → **GitHub Apps**. | ||
| 3. Find the GitHub App you created in step 1 and click on it. | ||
| 4. Click **Install App** in the left sidebar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 4. Click **Install App** in the left sidebar. | |
| 4. In the left sidebar, click **Install App**. |
| Once the collector service is running and the GitHub App is installed on your GHE organization(s), complete the integration setup as instructed in the New Relic UI: | ||
|
|
||
| 1. The corresponding GHE organizations will appear in the New Relic UI. | ||
| 2. Click **First time sync** to start the initial data synchronization. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 2. Click **First time sync** to start the initial data synchronization. | |
| 2. To start the initial data synchronization, click **First time sync**. |
|
|
||
| 1. The corresponding GHE organizations will appear in the New Relic UI. | ||
| 2. Click **First time sync** to start the initial data synchronization. | ||
| 3. *(Optional)* Click **On-demand sync** to manually sync the data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this a step in the setup?
|
|
||
| On the **GitHub Enterprise integration** screen: | ||
|
|
||
| * Click **Go to Teams** to view the imported teams information on [Teams](/docs/service-architecture-intelligence/teams/teams). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * Click **Go to Teams** to view the imported teams information on [Teams](/docs/service-architecture-intelligence/teams/teams). | |
| * To view the imported teams information on [Teams](/docs/service-architecture-intelligence/teams/teams), click **Go to Teams**. |
| On the **GitHub Enterprise integration** screen: | ||
|
|
||
| * Click **Go to Teams** to view the imported teams information on [Teams](/docs/service-architecture-intelligence/teams/teams). | ||
| * Click **Go to Repositories** to view the imported repositories information on [Catalogs](/docs/service-architecture-intelligence/catalogs/catalogs). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * Click **Go to Repositories** to view the imported repositories information on [Catalogs](/docs/service-architecture-intelligence/catalogs/catalogs). | |
| * To view the imported repositories information on [Catalogs](/docs/service-architecture-intelligence/catalogs/catalogs), click **Go to Repositories**. |
vpayyapilly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix and merge
No description provided.