Skip to content

Commit c9563c2

Browse files
committed
apply code review feedback and add a NULL check
1 parent 575aa95 commit c9563c2

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

agent/php_user_instrument_wraprec_hashmap.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,9 @@ static nruserfn_t* nr_func_hashmap_update_internal(nr_func_hashmap_t* hashmap, n
146146

147147
static void nr_func_hashmap_destroy_bucket_internal(nr_func_bucket_t** bucket_ptr) {
148148
nr_func_bucket_t* bucket = *bucket_ptr;
149-
nr_free(bucket->key->name);
149+
if (NULL != bucket->key) {
150+
nr_free(bucket->key->name);
151+
}
150152
nr_free(bucket->key);
151153
nr_php_user_wraprec_destroy(&bucket->wraprec);
152154
nr_realfree((void**)bucket_ptr);
@@ -307,7 +309,9 @@ static nr_func_hashmap_t* nr_scope_hashmap_update_internal(nr_scope_hashmap_t* h
307309

308310
static void nr_scope_hashmap_destroy_bucket_internal(nr_scope_bucket_t** bucket_ptr) {
309311
nr_scope_bucket_t* bucket = *bucket_ptr;
310-
nr_free(bucket->key->name);
312+
if (NULL != bucket->key) {
313+
nr_free(bucket->key->name);
314+
}
311315
nr_free(bucket->key);
312316
nr_func_hashmap_destroy_internal(&bucket->scoped_funcs_ht);
313317
nr_realfree((void**)bucket_ptr);

0 commit comments

Comments
 (0)