chore: remove vendor subdir #1012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1012 +/- ##
==========================================
- Coverage 77.40% 77.05% -0.36%
==========================================
Files 198 198
Lines 27715 27717 +2
==========================================
- Hits 21453 21357 -96
- Misses 6262 6360 +98
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lavarou
force-pushed
the
chore/remove-venodor-subdir
branch
from
d90a2f7 to
d516758
Compare
Abort build if protobuf-c cannot be found in the system without falling back to building and using protobuf-c from vendor subdir. axiom build needs protoc-c (provided by protobuf-c-compiler package) and agent needs to link to protobuf-c static library (provided by protobuf-c-devel). Static library is required to avoid shared objects runtime dependencies on customers' systems. Don't attempt to build protobuf compiler from vendor subdir - assume it is installed and let the build fail if it is not. protobuf compiler alone is not enough for the rule that used it anyway - protoc-gen-go is needed too, and it has never been vendored but rather was assumed to be installed on the build system. The rule that uses protobuf compiler and protoc-gen-go is not part of the build anyway - its output is checked in to the repository. The rule exists as documentation how to regenerate infinite tracing code for the daemon.
The agent uses protobuf-c library to provide support infinite tracing - infinite tracing endpoint speaks protobuf.
lavarou
force-pushed
the
chore/remove-venodor-subdir
branch
from
d516758 to
e28f504
Compare
mfulb
reviewed
Feb 19, 2025
| export GIT | ||
|
|
||
| .PHONY: vendor vendor-clean | ||
| .PHONY: protobuf-c |
There was a problem hiding this comment.
Why was the export GIT line removed?
mfulb
approved these changes
Feb 19, 2025
zsistla
approved these changes
Feb 21, 2025
lavarou
added a commit
that referenced
this pull request
Feb 25, 2025
Make the `HAVE_PROTOBUF_C != 0` check part of recipe where its needed rather than making the check in a phony target. Using phony target results in axiom rebuilding every time any target is build. Fixup of #1012.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the use of containerized build platforms, there's no need to vendor agent's build dependencies.