Release 11.6 #1022
Merged
Release 11.6 #1022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address issues spotted by `go vet`: - fix syntax of `kubernetes.KubernetesServiceHost` struct tags - ensure `context.cancel()` is always called to avoid context leak Add go vet check for pull requests.
1) Added message segment. Agent will now handle generic, external, datastore, and message segments. 2) Added unit tests for the changes 3) New functionality involves adding message specific attributes to segments/spans, generating message specific metrics, and honoring the message_tracer_parameters_enabled INI setting to disable/enable the attributes. 4)Things to keep in mind while reviewing: * the commits describe a lot of what is going on * Functionality-wise, message segment is a mix of external and datastore * nr_segment_message is the new file --------- Co-authored-by: ZNeumann <[email protected]> Co-authored-by: Michael Fulbright <[email protected]>
Uses message segments to create SQS instrumentation. Added unit tests and multiverse tests. --------- Co-authored-by: ZNeumann <[email protected]> Co-authored-by: Michael Fulbright <[email protected]> Co-authored-by: Michal Nowacki <[email protected]>
Instead of a blanket segment_start in the "before" function that needs to be discarded in the majority of the cases, just create the segment when it is needed, add the attributes/metrics, then close the segment. DONE:Multiverse SQS exception tests need to be updated. DONE:Needs additional testing against backend. --------- Co-authored-by: Michal Nowacki <[email protected]>
Free strings that were strdup-ed but not being freed.
…hashmap is destroyed (#1017) This function created a new hashmap, but didn's pass the string dtor in so any strdupped values were not being freed when the hashmap was destroyed. valgrind output from a multiverse run showed: ==220== by 0x6AA4680: nr_strdup (util_memory.c:156) ==220== by 0x6A83BD3: nr_header_create_distributed_trace_map (nr_header.c:60) ==220== by 0x6A45D28: nr_php_amqplib_retrieve_dt_headers (lib_php_amqplib.c:503) ==220== by 0x6A45D28: nr_rabbitmq_basic_get (lib_php_amqplib.c:742) ==220== by 0x6A74993: nr_zend_call_orig_execute_special (php_user_instrument.c:105) ==220== by 0x6A52EAA: nr_php_instrument_func_end (php_execute.c:2086) ==220== by 0x6A54D5B: nr_php_observer_fcall_end (php_execute.c:2188) ==220== by 0x71D7ED: zend_observer_fcall_end (in /usr/local/bin/php) ==220== by 0x6E79FF: execute_ex (in /usr/local/bin/php) ==220== by 0x6F0B42: zend_execute (in /usr/local/bin/php) ==220== by 0x67C06F: zend_execute_scripts (in /usr/local/bin/php) ==220== by 0x60FA3D: php_execute_script (in /usr/local/bin/php) after applying the fix, valgrind had no issues.
…ry (#1009) Most of the PR is basic instrumentation, retrieval of values and setting attributes or creating metrics and is very similar to patterns we've established in other instrumentation. The DT header insertion logic is the trickiest bit since we are modifying the headers in flight. (look to drupal and laravel for similar logic). Note: the DT header insertion logic, while trickiest, is something that can be turned off anytime by the user by setting newrelic.distributed_tracing_exclude_newrelic_header to true. Initial commit does the following: * Detect library via magic file * Detect package and version information. * Basic unit tests Subsequent commits: * Add attributes needed for rabbitMQ to message segment * Instrument basic_publish and basic_get * add unit tests, multiverse tests * added support for PHP 7.x * DT header insertion/retrieval * Added more multiverse tests, especially around the DT functionality
|
lavarou
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.