Skip to content

Conversation

mfulb
Copy link
Contributor

@mfulb mfulb commented Apr 18, 2025

No description provided.

bduranleau-nr and others added 7 commits March 19, 2025 12:53
The Monolog library tests have been moved to the multiverse tests.
This PR removes the test from the integration tests.
The PR also adds a test for the Monolog detection/state metrics to be
consistent with other logging libraries tested in the integration tests.
Added functionality to instrument
```
Call	                 collection(tablename)	operation	product

Create Table	TableName parameter	create_table	DynamoDB
Delete Item	TableName parameter	delete_item	DynamoDB
Delete Table	TableName parameter	delete_table	DynamoDB
Get Item	TableName parameter	get_item	DynamoDB
Put Item	TableName parameter	put_item	DynamoDB
Query	        TableName parameter	query	        DynamoDB
Scan	        TableName parameter	scan	        DynamoDB
Update Item	TableName parameter	update_item	DynamoDB
```

Unit tests added.
See also relevant multiverse PR.
See also relevant soak test PR.

Needed a modification to axiom to:
* add db.system
* modify datastore to allow for datastore that don't have concept of
database name
This PR adds the `nr_txn_suggest_package_supportability_metric` function
to Magento.
@mfulb mfulb requested a review from ZNeumann April 18, 2025 14:11
@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented Apr 18, 2025

Test Suite Status Result
Multiverse 8/8 passing
SOAK 83/83 passing

ZNeumann
ZNeumann previously approved these changes Apr 18, 2025
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2025

Codecov Report

Attention: Patch coverage is 54.86726% with 51 lines in your changes missing coverage. Please review.

Project coverage is 77.14%. Comparing base (4bb2f2a) to head (c6e98d1).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
agent/lib_aws_sdk_php.c 47.91% 50 Missing ⚠️
agent/lib_php_amqplib.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1051      +/-   ##
==========================================
- Coverage   77.40%   77.14%   -0.27%     
==========================================
  Files         198      198              
  Lines       27715    27991     +276     
==========================================
+ Hits        21453    21593     +140     
- Misses       6262     6398     +136     
Flag Coverage Δ
agent-for-php-7.2 77.45% <94.11%> (-0.08%) ⬇️
agent-for-php-7.3 77.47% <94.11%> (-0.08%) ⬇️
agent-for-php-7.4 77.19% <94.11%> (-0.08%) ⬇️
agent-for-php-8.0 76.58% <94.11%> (-0.08%) ⬇️
agent-for-php-8.1 76.90% <54.86%> (-0.27%) ⬇️
agent-for-php-8.2 76.51% <54.86%> (-0.26%) ⬇️
agent-for-php-8.3 76.51% <54.86%> (-0.26%) ⬇️
agent-for-php-8.4 76.53% <54.86%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…1050)

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.36.0 to
0.38.0.
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/golang/net/commit/e1fcd82abba34df74614020343be8eb1fe85f0d9"><code>e1fcd82</code></a>
html: properly handle trailing solidus in unquoted attribute value in
foreign...</li>
<li><a
href="https://github.com/golang/net/commit/ebed060e8f30f20235f74808c22125fd86b15edd"><code>ebed060</code></a>
internal/http3: fix build of tests with GOEXPERIMENT=nosynctest</li>
<li><a
href="https://github.com/golang/net/commit/1f1fa29e0a46fffe18c43a9da8daa5a0b180dfa9"><code>1f1fa29</code></a>
publicsuffix: regenerate table</li>
<li><a
href="https://github.com/golang/net/commit/12150816f701c912a32a376754ab28dd3878833a"><code>1215081</code></a>
http2: improve error when server sends HTTP/1</li>
<li><a
href="https://github.com/golang/net/commit/312450e473eae9f9e6173ad895c80bc5ea2f79ad"><code>312450e</code></a>
html: ensure &lt;search&gt; tag closes &lt;p&gt; and update tests</li>
<li><a
href="https://github.com/golang/net/commit/09731f9bf919b00b344c763894cd1920b3d96d90"><code>09731f9</code></a>
http2: improve handling of lost PING in Server</li>
<li><a
href="https://github.com/golang/net/commit/55989e24b972a90ab99308fdc7ea1fb58a96fef1"><code>55989e2</code></a>
http2/h2c: use ResponseController for hijacking connections</li>
<li><a
href="https://github.com/golang/net/commit/2914f46773171f4fa13e276df1135bafef677801"><code>2914f46</code></a>
websocket: re-recommend gorilla/websocket</li>
<li><a
href="https://github.com/golang/net/commit/99b3ae0643f9a2f9d820fcbba5f9e4c83b23bd48"><code>99b3ae0</code></a>
go.mod: update golang.org/x dependencies</li>
<li>See full diff in <a
href="https://github.com/golang/net/compare/v0.36.0...v0.38.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=golang.org/x/net&package-manager=go_modules&previous-version=0.36.0&new-version=0.38.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the
[Security Alerts
page](https://github.com/newrelic/newrelic-php-agent/network/alerts).

</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Amber Sistla <[email protected]>
@mfulb mfulb merged commit 2003afb into main Apr 18, 2025
129 of 130 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants