Skip to content

Conversation

lavarou
Copy link
Member

@lavarou lavarou commented May 12, 2025

Make log messages easier to understand when adding a named custom tracer by
logging only a single message. Instead of logging one message when the wraprec
is added, and two messages when wraprec is re-used, log a single message that
indicates if the wraprec was added or re-used.

lavarou added 3 commits May 12, 2025 10:45
Make log messages easier to understand when adding a named custom tracer by
logging only a single message. Instead of logging one message when the wraprec
is added, and two messages when wraprec is re-used, log a single message that
indicates if the wraprec was added or re-used.
@lavarou lavarou added this to the next-release milestone May 12, 2025
@lavarou lavarou requested a review from zsistla May 12, 2025 15:09
@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented May 12, 2025

Test Suite Status Result
Multiverse 7/8 passing
SOAK 85/85 passing

ZNeumann
ZNeumann previously approved these changes May 12, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.27%. Comparing base (1099f17) to head (044cbd2).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1060      +/-   ##
==========================================
+ Coverage   77.08%   77.27%   +0.19%     
==========================================
  Files         198      199       +1     
  Lines       28126    28328     +202     
==========================================
+ Hits        21680    21891     +211     
+ Misses       6446     6437       -9     
Flag Coverage Δ
agent-for-php-7.2 77.49% <100.00%> (+0.02%) ⬆️
agent-for-php-7.3 77.51% <100.00%> (?)
agent-for-php-7.4 77.38% <100.00%> (?)
agent-for-php-8.0 76.57% <100.00%> (?)
agent-for-php-8.1 76.89% <100.00%> (+<0.01%) ⬆️
agent-for-php-8.2 76.50% <100.00%> (+<0.01%) ⬆️
agent-for-php-8.3 76.50% <100.00%> (?)
agent-for-php-8.4 76.52% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lavarou
Copy link
Member Author

lavarou commented May 12, 2025

Superseded by #1061.

@lavarou lavarou closed this May 12, 2025
@lavarou lavarou removed this from the next-release milestone May 12, 2025
@lavarou lavarou deleted the refactor/improve-logging-when-adding-wraprecs branch May 12, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants