Skip to content

test(integration): improve valgrind #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 17, 2025
Merged

test(integration): improve valgrind #1065

merged 6 commits into from
Jun 17, 2025

Conversation

ZNeumann
Copy link
Contributor

@ZNeumann ZNeumann commented May 16, 2025 •
edited
Loading

This PR:

  1. adds the option to run valgrind on integration tests in GHA
  2. adds the ability to run valgrind on CGI tests
  3. no longer runs valgrind on SKIPIFs
  4. changes the valgrind lock mechanism to allow subprocesses (i.e. curl) to not be locked out

@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented May 16, 2025 •
edited
Loading

Test Suite Status Result
Multiverse ✅ 8/8 passing
SOAK ❌ 80/85 passing

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.27%. Comparing base (f2c18ed) to head (e953a97).

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev    #1065   +/-   ##
=======================================
  Coverage   77.27%   77.27%           
=======================================
  Files         199      199           
  Lines       28342    28342           
=======================================
  Hits        21902    21902           
  Misses       6440     6440
Flag Coverage Δ
agent-for-php-7.2 77.47% <ø> (ø)
agent-for-php-7.3 77.49% <ø> (ø)
agent-for-php-7.4 77.36% <ø> (ø)
agent-for-php-8.0 76.56% <ø> (ø)
agent-for-php-8.1 76.88% <ø> (ø)
agent-for-php-8.2 76.50% <ø> (ø)
agent-for-php-8.3 76.50% <ø> (ø)
agent-for-php-8.4 76.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lavarou lavarou self-requested a review May 20, 2025 15:32
lavarou
lavarou previously approved these changes May 21, 2025
View reviewed changes
@ZNeumann ZNeumann requested a review from zsistla May 27, 2025 20:10
@ZNeumann ZNeumann merged commit c6ee0c2 into dev Jun 17, 2025
65 checks passed
@lavarou lavarou added this to the next-release milestone Jun 20, 2025
hahuja2 pushed a commit that referenced this pull request Jul 9, 2025
@ZNeumann @hahuja2
test(integration): improve valgrind (#1065)
4da4f35 
This PR:
1) adds the option to run valgrind on integration tests in GHA
2) adds the ability to run valgrind on CGI tests
3) no longer runs valgrind on SKIPIFs
4) changes the valgrind lock mechanism to allow subprocesses (i.e. curl)
to not be locked out
@ZNeumann ZNeumann deleted the zjn/valgrind branch September 5, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsistla zsistla zsistla approved these changes

@lavarou lavarou lavarou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
11.10.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ZNeumann @newrelic-php-agent-bot @codecov-commenter @zsistla @lavarou