fix(agent): nr_execute_handle_autoload needs null check for txn #1086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nr_execute_handle_autoload wasn't accounting for the possibility of txn being null.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1086 +/- ##
==========================================
- Coverage 77.27% 77.27% -0.01%
==========================================
Files 199 199
Lines 28327 28329 +2
==========================================
+ Hits 21890 21891 +1
- Misses 6437 6438 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lavarou
approved these changes
Jun 5, 2025
This was referenced Jun 25, 2025
hahuja2
pushed a commit
that referenced
this pull request
Jul 9, 2025
`nr_execute_handle_autoload` wasn't accounting for the possibility of txn being null which would lead to unpredictable behavior when accessing it [here](https://github.com/newrelic/newrelic-php-agent/blob/dev/agent/php_execute.c#L894), and we would cause corruption when we [set this value](https://github.com/newrelic/newrelic-php-agent/blob/dev/agent/php_execute.c#L907). txn can be null in cases where nr_php_txn_end has been called. such as: https://github.com/newrelic/newrelic-php-agent/blob/dev/agent/fw_laravel_queue.c#L355-L356
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nr_execute_handle_autoloadwasn't accounting for the possibility of txn being null which would lead to unpredictable behavior when accessing it here, and we would cause corruption when we set this value.txn can be null in cases where nr_php_txn_end has been called.
such as: https://github.com/newrelic/newrelic-php-agent/blob/dev/agent/fw_laravel_queue.c#L355-L356