Skip to content

Conversation

hahuja2
Copy link
Contributor

@hahuja2 hahuja2 commented Jul 8, 2025

No description provided.

hahuja2 added 25 commits July 8, 2025 09:26
This PR removes kohana from the agent codebase.
This PR removes silex from the agent codebase.
This PR removes guzzle `3.x` from the agent codebase.
This PR removes symfony `1.x-3.x` from the agent codebase.
….x (#1064)

This PR removes Zend 1.x/2.x support and refactors the existing
instrumentation to only support Zend 3.x
This PR removes obsolete `PHP7` codeblocks. PR: 1/17
This PR removes obsolete `PHP7` codeblocks. PR: 2/17
This PR removes obsolete `PHP7` codeblocks. PR: 3/17
This PR removes obsolete `PHP7` codeblocks. PR: 4/17
This PR removes obsolete `PHP7` codeblocks. PR: 5/17
This PR removes obsolete `PHP7` codeblocks. PR: 6/17
This PR removes obsolete `PHP7` codeblocks. PR: 7/17
This PR removes obsolete `PHP7` codeblocks. PR: 8/17
This PR removes obsolete `PHP7` codeblocks. PR: 9/17
This PR removes obsolete `PHP7` codeblocks. PR: 10/17
This PR removes obsolete `PHP7` codeblocks. PR: 11/17
This PR removes obsolete `PHP7` codeblocks. PR: 12/17
This PR removes obsolete `PHP7` codeblocks. PR: 13/17
This PR removes obsolete `PHP7` codeblocks. PR: 15/17
This PR removes obsolete `PHP7` codeblocks. PR: 16/17
This PR removes obsolete `PHP7` codeblocks. PR: 14/17
This PR removes the `PHP7` macro and the remaining uses of it in the
agent codebase.
…r below (#1067)

This PR removes all integration tests that run only on PHP 7.1 or below.
…1092)

This PR removes obsolete PHP 7.0/7.1 `ZEND_MODULE_API_NO` usage from the
agent codebase.
This PR removes obsolete PHP 5.x `ZEND_MODULE_API_NO` usage from the
agent codebase.
@hahuja2 hahuja2 added this to the Removing Obsolete Code milestone Jul 8, 2025
@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented Jul 8, 2025

Test Suite Status Result
Multiverse 5/8 passing
SOAK 85/85 passing

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2025

Codecov Report

Attention: Patch coverage is 59.25926% with 11 lines in your changes missing coverage. Please review.

Project coverage is 78.13%. Comparing base (546c0e5) to head (c60eafe).

Files with missing lines Patch % Lines
agent/fw_zend3.c 0.00% 5 Missing ⚠️
agent/php_call.c 42.85% 4 Missing ⚠️
agent/lib_zend_http.c 0.00% 1 Missing ⚠️
agent/php_agent.c 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1098      +/-   ##
==========================================
+ Coverage   77.20%   78.13%   +0.93%     
==========================================
  Files         199      193       -6     
  Lines       28343    27976     -367     
==========================================
- Hits        21882    21859      -23     
+ Misses       6461     6117     -344     
Flag Coverage Δ
agent-for-php-7.2 78.37% <48.14%> (+0.97%) ⬆️
agent-for-php-7.3 78.39% <59.25%> (+0.97%) ⬆️
agent-for-php-7.4 78.25% <59.25%> (+0.97%) ⬆️
agent-for-php-8.0 77.46% <52.38%> (+0.96%) ⬆️
agent-for-php-8.1 77.77% <52.38%> (+0.96%) ⬆️
agent-for-php-8.2 77.38% <52.38%> (+0.95%) ⬆️
agent-for-php-8.3 77.38% <52.38%> (+0.95%) ⬆️
agent-for-php-8.4 77.40% <52.38%> (+0.95%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hahuja2 hahuja2 requested review from mfulb and bduranleau-nr July 9, 2025 16:49
@hahuja2 hahuja2 merged commit f58a459 into dev Jul 9, 2025
65 checks passed
@hahuja2 hahuja2 deleted the remove-obsolete-code branch July 9, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants