-
Notifications
You must be signed in to change notification settings - Fork 70
feat(agent): Add sampling control based on upstream sampling decisions #1104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1104 +/- ##
==========================================
+ Coverage 78.11% 78.14% +0.02%
==========================================
Files 193 193
Lines 27991 28039 +48
==========================================
+ Hits 21866 21910 +44
- Misses 6125 6129 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tests/integration/distributed_tracing/w3c/test_force_keep_headers_not_sampled_non_newrelic.php
Outdated
Show resolved
Hide resolved
tests/integration/distributed_tracing/w3c/test_force_keep_headers_not_sampled_non_newrelic.php
Outdated
Show resolved
Hide resolved
tests/integration/distributed_tracing/w3c/test_force_keep_headers_not_sampled.php
Show resolved
Hide resolved
tests/integration/distributed_tracing/w3c/test_force_keep_headers_sampled_non_newrelic.php
Outdated
Show resolved
Hide resolved
tests/integration/distributed_tracing/w3c/test_force_toss_headers_not_sampled.php
Show resolved
Hide resolved
tests/integration/distributed_tracing/w3c/test_force_toss_headers_sampled_non_newrelic.php
Outdated
Show resolved
Hide resolved
tests/integration/distributed_tracing/w3c/test_force_keep_headers_not_sampled_non_newrelic.php
Outdated
Show resolved
Hide resolved
tests/integration/distributed_tracing/w3c/test_force_keep_headers_not_sampled_non_newrelic.php
Outdated
Show resolved
Hide resolved
'traceparent' => "00-74be672b84ddc4e4b28be285632bbc0a-27ddd2d8890283b4-00", | ||
'tracestate' => "123@nr=0-0-1349956-41346604-27ddd2d8890283b4-b28be285632bbc0a-1-1.1273-1569367663277" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is interesting case: traceparent flags don't have sampled set, but New Relic's tracestate has sampled flag set. Regardless, agent respects always_off. This test also shows that remote_parent_not_sampled INI is only applicable to tracestate's sampled flag.
Co-authored-by: Michal Nowacki <[email protected]>
Co-authored-by: Michal Nowacki <[email protected]>
Co-authored-by: Michal Nowacki <[email protected]>
…ers_not_sampled_non_newrelic.php Co-authored-by: Michal Nowacki <[email protected]>
…ers_not_sampled_non_newrelic.php Co-authored-by: Michal Nowacki <[email protected]>
This implements the sampling spec to allow control over the agent sampling decisions based on the value in the sampled flag of an inbound traceparent header.