Skip to content

Conversation

lavarou
Copy link
Member

@lavarou lavarou commented Aug 12, 2025

When agent is not recording, Observer API fcall_init callback shouldn't do anything, including framework detection. This is how the agent operated before it used Observer API to hook into Zend Engine.

When agent is not recording, Observer API fcall_init callback shouldn't do
anything, including framework detection. This is how the agent operated
before it used Observer API to hook into Zend Engine.
@lavarou lavarou added this to the next-release milestone Aug 12, 2025
@lavarou lavarou requested a review from zsistla August 12, 2025 16:02
@lavarou lavarou self-assigned this Aug 12, 2025
@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented Aug 12, 2025

Test Suite Status Result
Multiverse 16/16 passing
SOAK 85/85 passing

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.11%. Comparing base (2f79c48) to head (9c935fa).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1112      +/-   ##
==========================================
- Coverage   78.12%   78.11%   -0.01%     
==========================================
  Files         193      193              
  Lines       27989    27991       +2     
==========================================
  Hits        21866    21866              
- Misses       6123     6125       +2     
Flag Coverage Δ
agent-for-php-7.2 78.37% <ø> (ø)
agent-for-php-7.3 78.38% <ø> (ø)
agent-for-php-7.4 78.24% <ø> (ø)
agent-for-php-8.0 77.44% <100.00%> (-0.01%) ⬇️
agent-for-php-8.1 77.76% <100.00%> (-0.01%) ⬇️
agent-for-php-8.2 77.37% <100.00%> (-0.01%) ⬇️
agent-for-php-8.3 77.37% <100.00%> (-0.01%) ⬇️
agent-for-php-8.4 77.39% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lavarou lavarou merged commit 22d0138 into dev Aug 12, 2025
65 checks passed
@lavarou lavarou deleted the fix/agent/dont-register-observers-when-not-recording branch August 12, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants