-
Notifications
You must be signed in to change notification settings - Fork 69
fix(agent): Fix Laravel queue job exception handling #1122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zsistla
wants to merge
14
commits into
dev
Choose a base branch
from
laravel_queue_exception_handling
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting txn within agent
In case the queue process txn that we keep open so we caninstrument actually becomes a real txn, name it.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1122 +/- ##
==========================================
+ Coverage 78.15% 78.44% +0.28%
==========================================
Files 193 193
Lines 28053 28053
==========================================
+ Hits 21925 22006 +81
+ Misses 6128 6047 -81
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lavarou
reviewed
Sep 22, 2025
lavarou
reviewed
Sep 22, 2025
lavarou
reviewed
Sep 22, 2025
lavarou
reviewed
Sep 22, 2025
lavarou
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiverse and soak tests revealed a bug with naming Job transactions when the job throws an exception.
The issue is that we key off of raiseBeforeJobEvent and raiseAfterJobEvent, but in the case of failure due to exception(https://github.com/illuminate/queue/blob/12.x/Worker.php#L447 ), raiseAfterJobEvent doesn't get called, so we never do the final end txn to close things off here and when the next retry calls raiseBeforeJobEvent again it ends the txn and discards anything that happened before (in this case the logs/exceptions/segment of the previous retry attempt).
Solution is to wrap the following so we can handle the exception case in the after/clean callbacks.
{Illuminate\Queue\Worker} function={process} async
https://github.com/illuminate/queue/blob/12.x/Worker.php#L425
Illuminate\Queue\SyncQueue::executeJob/push for sync
https://github.com/illuminate/queue/blob/12.x/SyncQueue.php#L123