Skip to content

feat(agent): end transaction for laravel horizon #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from
Open

feat(agent): end transaction for laravel horizon #1123

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
de6f6cf
feat(agent): end transaction for laravel horizon
hahuja2 Sep 23, 2025
ed39176
chore(agent): change function location to inside of conditional
hahuja2 Sep 24, 2025
a858026
chore(tests): add integration tests for laravel horizon
hahuja2 Sep 24, 2025
3c1cf7e
chore(tests): update string
hahuja2 Sep 24, 2025
3244b68
chore(tests): update description
hahuja2 Sep 24, 2025
61a0d34
chore(tests): update string
hahuja2 Sep 24, 2025
e98209e
chore(tests): add skipif
hahuja2 Sep 24, 2025
c777c6f
chore(agent): add comment
hahuja2 Sep 29, 2025
c1712c5
chore(tests): update tests with EXPECT_REGEX
hahuja2 Sep 30, 2025
f049a15
chore(agent): change function name
hahuja2 Sep 30, 2025
d8e9adb
chore(agent): ensure transaction is always stopped when laravel horiz…
hahuja2 Oct 3, 2025
819903e
chore(agent): change verbosedebug to use NRL_FRAMEWORK logging subsystem
hahuja2 Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions agent/fw_laravel_queue.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -839,6 +839,14 @@ NR_PHP_WRAPPER(nr_laravel_queue_queue_createpayload) {
}
NR_PHP_WRAPPER_END

NR_PHP_WRAPPER(nr_laravel_horizon_end) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer a name like nr_laravel_horizon_end_txn to be more clear what this function does.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, updated the name: f049a15

NR_UNUSED_SPECIALFN;
(void)wraprec;

nr_php_txn_end(1, 0 TSRMLS_CC);
}
NR_PHP_WRAPPER_END

void nr_laravel_queue_enable(TSRMLS_D) {
/*
* Hook the command class that implements Laravel's queue:work command so
Expand Down Expand Up @@ -892,6 +900,13 @@ void nr_laravel_queue_enable(TSRMLS_D) {
nr_laravel_queue_workcommand_handle TSRMLS_CC);
#endif

nr_php_wrap_user_function_before_after_clean(
NR_PSTR("Laravel\\Horizon\\Console\\HorizonCommand::handle"),
nr_laravel_horizon_end, NULL, NULL);

nr_php_wrap_user_function_before_after_clean(
NR_PSTR("Laravel\\Horizon\\Console\\SupervisorCommand::handle"),
nr_laravel_horizon_end, NULL, NULL);
/*
* Hook the method that creates the JSON payloads for queued jobs so that we
* can add our metadata for CATMQ.
Expand Down
Loading