Skip to content

Release 11.1 #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 23, 2024
Merged

Release 11.1 #951

merged 4 commits into from
Aug 23, 2024

Conversation

mfulb
Copy link
Contributor

@mfulb mfulb commented Aug 23, 2024

No description provided.

zsistla and others added 4 commits August 6, 2024 07:50
@zsistla
chore: Bump version to 11.1 (#945)
1291a76
@mfulb
fix(testing): Fixes count check for apdex metrics (#946)
a95eb51 
The current code for EXPECT_METRICS_EXIST would verify the count of any
metric was >0 before passing the test. However, with apdex metrics the
first field is not the count of metrics but the count of the number of
times the transaction time was less than apdex_t. This change allows for
the count to be 0 for apdex metrics.
@mfulb
chore(agent): Changes code to use NR string routines (#949)
010f1f1 
Switches to use nr_strlcpy and nr_strcpy instead of libc versions for
better platform generality.
@mfulb @lavarou
feat(agent): Adds supportability metrics for PHP and agent version (#947
0ba870b 
)

Adds supportability metrics for the agent and PHP version.

I did clean up some ZTS macros as well but I think it is obvious what is
a real change and what isnt.

---------

Co-authored-by: Michal Nowacki <[email protected]>
@mfulb mfulb requested a review from lavarou August 23, 2024 14:04
@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented Aug 23, 2024 •
edited
Loading

Test Suite Status Result
Multiverse ✅ 7/7 passing
SOAK ✅ 56/56 passing

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.32%. Comparing base (ef7200a) to head (0ba870b).

Files Patch % Lines
agent/php_txn.c 91.30% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #951      +/-   ##
==========================================
+ Coverage   78.13%   78.32%   +0.19%     
==========================================
  Files         194      194              
  Lines       26857    26880      +23     
==========================================
+ Hits        20984    21055      +71     
+ Misses       5873     5825      -48
Flag Coverage Δ
agent-for-php-7.2 78.33% <92.30%> (+0.20%) ⬆️
agent-for-php-7.3 78.35% <92.30%> (+0.20%) ⬆️
agent-for-php-7.4 78.06% <92.30%> (+0.20%) ⬆️
agent-for-php-8.0 78.08% <92.30%> (+0.20%) ⬆️
agent-for-php-8.1 78.07% <92.30%> (+0.20%) ⬆️
agent-for-php-8.2 77.67% <92.30%> (+0.20%) ⬆️
agent-for-php-8.3 77.67% <92.30%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mfulb mfulb merged commit 263681e into main Aug 23, 2024
110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavarou lavarou lavarou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mfulb @newrelic-php-agent-bot @codecov-commenter @lavarou @zsistla