Skip to content

Conversation

mfulb
Copy link
Contributor

@mfulb mfulb commented Aug 27, 2024

The existing code did not handle an Apdex metric correctly if a count of "1" was specified. It only worked if no count was specified. This change allows either form to work.

The existing code did not handle an Apdex metric correctly if a count of "1" was specified.  It only worked if no count was specified.  This change allows either form to work.
@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented Aug 27, 2024

Test Suite Status Result
Multiverse 7/7 passing
SOAK 55/56 passing

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.32%. Comparing base (819a76d) to head (b012663).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #957   +/-   ##
=======================================
  Coverage   78.32%   78.32%           
=======================================
  Files         194      194           
  Lines       26880    26880           
=======================================
  Hits        21055    21055           
  Misses       5825     5825           
Flag Coverage Δ
agent-for-php-7.2 78.33% <ø> (ø)
agent-for-php-7.3 78.35% <ø> (ø)
agent-for-php-7.4 78.06% <ø> (ø)
agent-for-php-8.0 78.08% <ø> (ø)
agent-for-php-8.1 78.07% <ø> (ø)
agent-for-php-8.2 77.67% <ø> (ø)
agent-for-php-8.3 77.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mfulb mfulb requested a review from hahuja2 August 28, 2024 13:39
@mfulb mfulb merged commit 8a5c2f8 into dev Aug 30, 2024
57 checks passed
@mfulb mfulb deleted the fix/integ-runner-apdex-metric-count branch August 30, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants