Skip to content

Conversation

bduranleau-nr
Copy link
Contributor

No description provided.

mfulb and others added 7 commits August 26, 2024 15:36
The existing code did not handle an Apdex metric correctly if a count of
"1" was specified. It only worked if no count was specified. This change
allows either form to work.
Starting with PHP 8.0 the `set_error_handler()` callback function
signature drops the `$errcontext` final parameter so it only contains 4
parameters. This caused using `newrelic_notice_error()` as a callback
handler for PHP 8+ to not work as the API call did not accept only 4
arguments. This PR adds support for this function signature. There are
also numerous tests added that will hopefully caught this kind of issue
in the future.

---------

Co-authored-by: Amber Sistla <[email protected]>
Co-authored-by: Hitesh Ahuja <[email protected]>
If possible, use Composer's runtime API to collect information about PHP
packages used by the application for New Relic Vulnerability Management.
This feature is disabled by default and can be enabled by setting
`newrelic.vulnerability_management.composer_detection.enabled` to `true`.

---------

Co-authored-by: Hitesh Ahuja <[email protected]>
Co-authored-by: bduranleau-nr <[email protected]>
Co-authored-by: Hitesh Ahuja <[email protected]>
Co-authored-by: Amber Sistla <[email protected]>
Co-authored-by: Michael Fulbright <[email protected]>
@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented Sep 27, 2024

Test Suite Status Result
Multiverse 7/7 passing
SOAK 56/56 passing

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 79.34272% with 44 lines in your changes missing coverage. Please review.

Project coverage is 78.50%. Comparing base (79e86d3) to head (ce3dd6d).

Files with missing lines Patch % Lines
agent/lib_composer.c 77.08% 22 Missing ⚠️
axiom/nr_php_packages.c 72.00% 7 Missing ⚠️
agent/fw_laminas3.c 0.00% 2 Missing ⚠️
agent/fw_lumen.c 0.00% 2 Missing ⚠️
agent/fw_wordpress.c 0.00% 2 Missing ⚠️
agent/lib_doctrine2.c 0.00% 2 Missing ⚠️
agent/lib_mongodb.c 0.00% 2 Missing ⚠️
agent/lib_phpunit.c 0.00% 2 Missing ⚠️
axiom/nr_php_packages.h 60.00% 2 Missing ⚠️
agent/fw_slim.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #966      +/-   ##
==========================================
+ Coverage   78.32%   78.50%   +0.17%     
==========================================
  Files         194      195       +1     
  Lines       26880    27057     +177     
==========================================
+ Hits        21055    21241     +186     
+ Misses       5825     5816       -9     
Flag Coverage Δ
agent-for-php-7.2 78.51% <79.34%> (+0.18%) ⬆️
agent-for-php-7.3 78.53% <79.34%> (+0.18%) ⬆️
agent-for-php-7.4 78.23% <78.40%> (+0.17%) ⬆️
agent-for-php-8.0 78.25% <78.30%> (+0.17%) ⬆️
agent-for-php-8.1 78.24% <78.30%> (+0.17%) ⬆️
agent-for-php-8.2 77.84% <77.83%> (+0.16%) ⬆️
agent-for-php-8.3 77.84% <77.83%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bduranleau-nr bduranleau-nr merged commit 2321b9e into main Sep 27, 2024
110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants