Skip to content

Conversation

ZNeumann
Copy link
Contributor

No description provided.

bduranleau-nr and others added 6 commits October 2, 2024 16:55
These metrics can be used by the backend to create AWS relationship maps
with memcached

---------

Co-authored-by: Michal Nowacki <[email protected]>
Speed up package detection by performing a suffix match on the
'magic' file pattern with case insensitive string comparison instead of
a substring search within a lowercased filename. This is possible
because all of the 'magic' file search patterns patterns are right
anchored.

Fixup of e11b992 with changes from 24c1c65.
Speed up magic file recognition performance by removing
files from `libraries` and `logging_frameworks` that belong
to old and un-instrumented packages.
)

Debian uses a directory called "mods-available" to house ini files. It's
`phpenmod` and `phpdismod` allow command-line management of extensions
in directory. It also creates a symlink ini file to this
"mods-available" directory in the normal conf.d directory. The issue is
that this symlink is prefixed with a number (for example
20-newrelic.ini). This prefix prevents our tarball installer from
recognizing that a newrelic.ini already exists, resulting in 2 ini
files: a newrelic.ini and a 20-newrelic.ini.

Our .deb package installer scouts out the "mods-available" directory and
installs therein when possible. That means that if a customer installs
via package but upgrades via tarball (not recommended), then their
system gets the duplicates.

This change makes our tarball installer scout for a potential previous
installation in mods-available.

Fixes #399

---------

Co-authored-by: Michal Nowacki <[email protected]>
@ZNeumann ZNeumann requested a review from zsistla October 18, 2024 16:10
@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented Oct 18, 2024

Test Suite Status Result
Multiverse 7/7 passing
SOAK 56/56 passing

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 96.77419% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.54%. Comparing base (2321b9e) to head (dc162a4).

Files with missing lines Patch % Lines
agent/php_internal_instrument.c 94.28% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #978      +/-   ##
==========================================
+ Coverage   78.50%   78.54%   +0.03%     
==========================================
  Files         195      196       +1     
  Lines       27057    27103      +46     
==========================================
+ Hits        21241    21287      +46     
  Misses       5816     5816              
Flag Coverage Δ
agent-for-php-7.2 78.55% <96.77%> (+0.03%) ⬆️
agent-for-php-7.3 78.57% <96.77%> (+0.03%) ⬆️
agent-for-php-7.4 78.27% <96.77%> (+0.03%) ⬆️
agent-for-php-8.0 78.29% <96.66%> (+0.03%) ⬆️
agent-for-php-8.1 78.28% <96.66%> (+0.03%) ⬆️
agent-for-php-8.2 77.87% <96.66%> (+0.03%) ⬆️
agent-for-php-8.3 77.87% <96.66%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hahuja2 hahuja2 self-requested a review October 18, 2024 18:34
@ZNeumann ZNeumann merged commit f30642f into main Oct 18, 2024
108 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants