Fix Issues Related to Path.parent with no Parent Directory#1434
Merged
hmstepanek merged 3 commits intomainfrom Jul 30, 2025
Merged
Fix Issues Related to Path.parent with no Parent Directory#1434hmstepanek merged 3 commits intomainfrom
hmstepanek merged 3 commits intomainfrom
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1434 +/- ##
==========================================
- Coverage 81.37% 81.34% -0.03%
==========================================
Files 208 208
Lines 23563 23563
Branches 3716 3716
==========================================
- Hits 19174 19168 -6
- Misses 3132 3137 +5
- Partials 1257 1258 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hmstepanek
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Overview
pathlib.Path.parenton a command line path, that may have no parent directory listed.PATHto find an executable of this name. Instead, the current change is interpreting no parent as./, producing incorrect results.os.path.dirnamefor this specific use case, and ignorePTHlinter.Testing
newrelic-admin run-program flask runandnewrelic-admin run-python main.py.sys.argv[0]being an executable with no path, but there's probably not a lot of risk. The comments indicate this is generally a Heroku only thing as well.