Skip to content

Add Windows Test Runners for All Core Test Suites #1439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 28 commits into
base: develop-windows
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
ecd4d75
Don't build some extensions on windows
TimPansino Jul 21, 2025
72e9ecb
Add windows test runners for all core test suites
TimPansino Jul 21, 2025
c2143de
Update get-envs script to replace grep
TimPansino Jul 31, 2025
e5b29a4
Fix missing lambda handler deprecation
TimPansino Aug 8, 2025
5689056
Fix paths in logs in context tests
TimPansino Aug 8, 2025
24cd182
agent_features: Skip all failing windows tests for now
TimPansino Aug 8, 2025
abd75b6
agent_unittests: Skip all failing windows tests for now
TimPansino Aug 8, 2025
75217c1
cross_agent: Skip all failing windows tests for now
TimPansino Aug 8, 2025
3a97d9f
Convert username lookup to more portable option
TimPansino Jul 21, 2025
58e1d8e
Fix handling of health dir paths on Windows
TimPansino Jul 22, 2025
35d9519
Fix issues related to tempfile on Windows
TimPansino Jul 28, 2025
5499fd8
Fix encoding in test fixtures
TimPansino Jul 31, 2025
ff449b1
Fix globbing on Windows
TimPansino Jul 31, 2025
fcc715e
Format
TimPansino Jul 31, 2025
d402d74
Fix Python 3.7 compat
TimPansino Aug 4, 2025
ff6be99
Drop windows py37 tests
TimPansino Aug 13, 2025
799810b
Update build_ext_errors in setup.py for modern versions
TimPansino Aug 13, 2025
077f8e3
Reduce windows testing scope to 3.13
TimPansino Aug 14, 2025
0052853
Change out windows xfails
TimPansino Aug 14, 2025
d041027
Enable colors in CI logs on Windows
TimPansino Aug 14, 2025
fece9a8
Update all python-version specs in CI
TimPansino Aug 14, 2025
3e3a2c3
Update coverage source paths
TimPansino Aug 14, 2025
33d598a
Add inline pytest ids to unittests
TimPansino Aug 15, 2025
a6d35e5
Add tests for all OS and arch combinations
TimPansino Aug 16, 2025
aaf4717
Remove mac tests for now
TimPansino Aug 18, 2025
4762065
Disable agent_streaming on windows arm64
TimPansino Aug 18, 2025
4c42b05
Lint with actionlint
TimPansino Aug 18, 2025
d94deca
Add wait to collector_available_fixture to fix race condition
TimPansino Aug 18, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions .github/actionlint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# Copyright 2010 New Relic, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

paths:
.github/workflows/**/*.{yml,yaml}:
ignore:
# This runner exists, but is in beta and not known to actionlint.
- 'label "windows-11-arm" is unknown\. .+'
51 changes: 51 additions & 0 deletions .github/scripts/get-envs.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
#!/usr/bin/env python
# Copyright 2010 New Relic, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

import fileinput
import os
from textwrap import dedent

GROUP_NUMBER = int(os.environ["GROUP_NUMBER"]) - 1
TOTAL_GROUPS = int(os.environ["TOTAL_GROUPS"])
GITHUB_JOB = os.environ["GITHUB_JOB"]


def main(stdin):
environments = [env.rstrip() for env in stdin]
filtered_envs = [env for env in environments if env.startswith(GITHUB_JOB + "-")]
grouped_envs = filtered_envs[GROUP_NUMBER::TOTAL_GROUPS]
joined_envs = ",".join(grouped_envs)

# If not environments are found, raise an error with helpful information.
if joined_envs:
print(joined_envs)
else:
error_msg = dedent(f"""
No matching environments found.
GITHUB_JOB = {GITHUB_JOB}
GROUP_NUMBER = {GROUP_NUMBER + 1}
TOTAL_GROUPS = {TOTAL_GROUPS}

environments = {environments}
filtered_envs = {filtered_envs}
grouped_envs = {grouped_envs}
joined_envs = {joined_envs}
""")
raise RuntimeError(error_msg(environments))


if __name__ == "__main__":
with fileinput.input() as stdin:
main(stdin)
42 changes: 0 additions & 42 deletions .github/scripts/retry.sh

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ jobs:

- uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # 5.6.0
with:
python-version: "3.12"
python-version: "3.13"

- name: Install Dependencies
run: |
Expand Down
36 changes: 0 additions & 36 deletions .github/workflows/get-envs.py

This file was deleted.

Loading
Loading