-
Notifications
You must be signed in to change notification settings - Fork 133
Add response token count logic to OpenAI instrumentation. #1498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅MegaLinter analysis: Success
See detailed reports in MegaLinter artifacts |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## feature-llm-token-counts #1498 +/- ##
============================================================
- Coverage 81.48% 73.61% -7.87%
============================================================
Files 209 209
Lines 23815 23841 +26
Branches 3753 3757 +4
============================================================
- Hits 19406 17551 -1855
- Misses 3153 5154 +2001
+ Partials 1256 1136 -120 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TimPansino
approved these changes
Sep 24, 2025
umaannamalai
added a commit
that referenced
this pull request
Nov 17, 2025
* Add OpenAI token counts. * Add token counts to langchain + openai tests. * Remove unused expected events. * Linting * Add OpenAI token counts. * Add token counts to langchain + openai tests. * Remove unused expected events. * [MegaLinter] Apply linters fixes --------- Co-authored-by: Tim Pansino <[email protected]>
umaannamalai
added a commit
that referenced
this pull request
Dec 11, 2025
* Add OpenAI token counts. * Add token counts to langchain + openai tests. * Remove unused expected events. * Linting * Add OpenAI token counts. * Add token counts to langchain + openai tests. * Remove unused expected events. * [MegaLinter] Apply linters fixes --------- Co-authored-by: Tim Pansino <[email protected]>
umaannamalai
added a commit
that referenced
this pull request
Dec 11, 2025
* Add OpenAI token counts. * Add token counts to langchain + openai tests. * Remove unused expected events. * Linting * Add OpenAI token counts. * Add token counts to langchain + openai tests. * Remove unused expected events. * [MegaLinter] Apply linters fixes --------- Co-authored-by: Tim Pansino <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

This PR updates OpenAI instrumentation and tests to pull token counts directly from the response object. If a customer has an LLM token counting callback function registered, this will still take priority over the response token count values.
It also removes token count calculations from error cases as the agent will consistently stop reporting token counts when a error was met during the creation of an embedding or chat completion.