Add support for partial granularity type #1532

hmstepanek · 2025-10-02T17:59:00Z

Overview

This adds support for the concept of partial granularity distributed traces. There are 3 types:

reduced
essential
compact

Add support for the following new configuration options:

distributed_tracing
   sampler
       adaptive_sampling_target
       full_granularity
           enabled
           remote_parent_sampled
           remote_parent_not_sampled
       partial_granularity
           enabled
           type
           remote_parent_sampled
           remote_parent_not_sampled

github-actions · 2025-10-02T18:00:19Z

✅MegaLinter analysis: Success

Descriptor	Linter	Files	Fixed	Elapsed time
✅ ACTION	actionlint	7		0.9s
✅ MARKDOWN	markdownlint	7	0	1.32s
✅ PYTHON	ruff	948	0	0.98s
✅ PYTHON	ruff-format	948	0	0.36s
✅ YAML	prettier	15	0	1.52s
✅ YAML	v8r	15		5.31s
✅ YAML	yamllint	15		0.69s

See detailed reports in MegaLinter artifacts

codecov-commenter · 2025-10-02T18:30:41Z

Codecov Report

❌ Patch coverage is 87.36842% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.73%. Comparing base (59633ac) to head (7fd81a6).
⚠️ Report is 3 commits behind head on develop-hybrid-core-tracing.

Files with missing lines	Patch %	Lines
newrelic/config.py	51.72%	14 Missing ⚠️
newrelic/core/node_mixin.py	94.54%	1 Missing and 2 partials ⚠️
newrelic/core/agent.py	50.00%	2 Missing ⚠️
newrelic/core/data_collector.py	71.42%	1 Missing and 1 partial ⚠️
newrelic/core/loop_node.py	33.33%	2 Missing ⚠️
newrelic/api/transaction.py	98.27%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@                       Coverage Diff                       @@
##           develop-hybrid-core-tracing    #1532      +/-   ##
===============================================================
- Coverage                        81.76%   81.73%   -0.04%     
===============================================================
  Files                              207      207              
  Lines                            23943    24067     +124     
  Branches                          3796     3817      +21     
===============================================================
+ Hits                             19576    19670      +94     
- Misses                            3101     3124      +23     
- Partials                          1266     1273       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

newrelic/core/node_mixin.py

newrelic/core/config.py

newrelic/api/transaction.py

* fix(aiomysql): avoid wrapping pooled connections multiple times * Move and rewrite regression test * Tweak implementation of fix --------- Co-authored-by: Tim Pansino <[email protected]>

newrelic/core/config.py

Bumps the github_actions group with 4 updates: [actions/upload-artifact](https://github.com/actions/upload-artifact), [actions/download-artifact](https://github.com/actions/download-artifact), [astral-sh/setup-uv](https://github.com/astral-sh/setup-uv) and [github/codeql-action](https://github.com/github/codeql-action). Updates `actions/upload-artifact` from 4.6.2 to 5.0.0 - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@ea165f8...330a01c) Updates `actions/download-artifact` from 5.0.0 to 6.0.0 - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@634f93c...018cc2c) Updates `astral-sh/setup-uv` from 7.1.1 to 7.1.2 - [Release notes](https://github.com/astral-sh/setup-uv/releases) - [Commits](astral-sh/setup-uv@2ddd2b9...8585678) Updates `github/codeql-action` from 4.30.9 to 4.31.0 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@16140ae...4e94bd1) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: 5.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: github_actions - dependency-name: actions/download-artifact dependency-version: 6.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: github_actions - dependency-name: astral-sh/setup-uv dependency-version: 7.1.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github_actions - dependency-name: github/codeql-action dependency-version: 4.31.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github_actions ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Timothy Pansino <[email protected]>

* fix(aiomysql): avoid wrapping pooled connections multiple times * Move and rewrite regression test * Tweak implementation of fix --------- Co-authored-by: Tim Pansino <[email protected]>

Bumps the github_actions group with 4 updates: [actions/upload-artifact](https://github.com/actions/upload-artifact), [actions/download-artifact](https://github.com/actions/download-artifact), [astral-sh/setup-uv](https://github.com/astral-sh/setup-uv) and [github/codeql-action](https://github.com/github/codeql-action). Updates `actions/upload-artifact` from 4.6.2 to 5.0.0 - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@ea165f8...330a01c) Updates `actions/download-artifact` from 5.0.0 to 6.0.0 - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@634f93c...018cc2c) Updates `astral-sh/setup-uv` from 7.1.1 to 7.1.2 - [Release notes](https://github.com/astral-sh/setup-uv/releases) - [Commits](astral-sh/setup-uv@2ddd2b9...8585678) Updates `github/codeql-action` from 4.30.9 to 4.31.0 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@16140ae...4e94bd1) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: 5.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: github_actions - dependency-name: actions/download-artifact dependency-version: 6.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: github_actions - dependency-name: astral-sh/setup-uv dependency-version: 7.1.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github_actions - dependency-name: github/codeql-action dependency-version: 4.31.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github_actions ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Timothy Pansino <[email protected]>

lrafeei · 2025-10-29T18:20:08Z

newrelic/core/config.py


    application_settings.attribute_filter = AttributeFilter(flatten_settings(application_settings))

+    simplify_distributed_tracing_sampler_granularity_settings(application_settings)


I just realized that simplify_distributed_tracing_sampler_granularity_settings() should either

be moved before the attribute_filter application, but right after apply_server_side_settings()

be removed all together and put the logic from that function in apply_server_side_settings() (maybe after the custom_insights_events.max_attribute_value override?)

lrafeei · 2025-10-30T20:58:12Z

newrelic/core/config.py


    application_settings.attribute_filter = AttributeFilter(flatten_settings(application_settings))

+    simplify_distributed_tracing_sampler_granularity_settings(application_settings)


Since the logic for this has now moved to apply_server_side_settings(), the call to this function can be removed

hmstepanek requested a review from a team as a code owner October 2, 2025 17:59

mergify bot added the tests-failing Tests failing in CI. label Oct 2, 2025

hmstepanek force-pushed the partial-granularity-type-support branch from 831fa32 to ca79220 Compare October 7, 2025 00:07

hmstepanek marked this pull request as draft October 7, 2025 00:08

hmstepanek force-pushed the partial-granularity-type-support branch 6 times, most recently from 303468c to 27573b4 Compare October 10, 2025 22:26

hmstepanek force-pushed the partial-granularity-type-support branch from 7282263 to b59cc63 Compare October 21, 2025 17:21

hmstepanek changed the base branch from main to develop-hybrid-core-tracing October 21, 2025 17:36

hmstepanek commented Oct 21, 2025

View reviewed changes

newrelic/core/node_mixin.py Show resolved Hide resolved

hmstepanek force-pushed the partial-granularity-type-support branch 3 times, most recently from 4c9dd32 to b962aba Compare October 22, 2025 07:13

hmstepanek commented Oct 22, 2025

View reviewed changes

newrelic/core/config.py Outdated Show resolved Hide resolved

hmstepanek marked this pull request as ready for review October 22, 2025 07:19

hmstepanek force-pushed the partial-granularity-type-support branch 2 times, most recently from 0262e1a to 81943d0 Compare October 22, 2025 08:25

hmstepanek commented Oct 22, 2025

View reviewed changes

newrelic/api/transaction.py Show resolved Hide resolved

hmstepanek force-pushed the develop-hybrid-core-tracing branch from e3f2de1 to 01b71d0 Compare October 22, 2025 17:32

mergify bot added the merge-conflicts Merge conflicts detected. label Oct 22, 2025

hmstepanek force-pushed the partial-granularity-type-support branch from ddd7851 to d3152cb Compare October 22, 2025 17:35

mergify bot removed the merge-conflicts Merge conflicts detected. label Oct 22, 2025

hmstepanek force-pushed the partial-granularity-type-support branch from d3152cb to eaa838d Compare October 22, 2025 21:02

hmstepanek force-pushed the develop-hybrid-core-tracing branch from 01b71d0 to 48c4420 Compare October 22, 2025 22:40

mergify bot added the merge-conflicts Merge conflicts detected. label Oct 22, 2025

mergify bot removed the merge-conflicts Merge conflicts detected. label Oct 24, 2025

hmstepanek force-pushed the partial-granularity-type-support branch from 79a37d6 to f96dced Compare October 24, 2025 00:23

Add support 4 partial granularity tracing

669f51e

hmstepanek force-pushed the partial-granularity-type-support branch from f96dced to 669f51e Compare October 24, 2025 00:48

fix(aiomysql): avoid wrapping pooled connections multiple times (#1553)

996ee66

* fix(aiomysql): avoid wrapping pooled connections multiple times * Move and rewrite regression test * Tweak implementation of fix --------- Co-authored-by: Tim Pansino <[email protected]>

lrafeei requested changes Oct 25, 2025

View reviewed changes

newrelic/core/config.py Outdated Show resolved Hide resolved

TimPansino and others added 9 commits October 27, 2025 11:13

Fix structlog tests (#1556)

6d7be8c

Add instrumentation for new kinesis method (#1557)

d1e7b60

Move config consolidation into global settings

09eaa22

Fix error when shutdown_agent called from harvest thread (#1552)

b9efe7e

fix(aiomysql): avoid wrapping pooled connections multiple times (#1553)

8a3eb42

* fix(aiomysql): avoid wrapping pooled connections multiple times * Move and rewrite regression test * Tweak implementation of fix --------- Co-authored-by: Tim Pansino <[email protected]>

Fix structlog tests (#1556)

3a83b40

Add instrumentation for new kinesis method (#1557)

edbfd79

hmstepanek force-pushed the partial-granularity-type-support branch from f29653a to edbfd79 Compare October 27, 2025 23:49

hmstepanek and others added 2 commits October 27, 2025 23:50

[MegaLinter] Apply linters fixes

f52e9bd

Trigger tests

923ad1d

hmstepanek requested a review from lrafeei October 28, 2025 22:30

lrafeei requested changes Oct 29, 2025

View reviewed changes

Add free-threaded Python to CI (#1562)

953f379

hmstepanek requested a review from lrafeei October 30, 2025 20:35

lrafeei reviewed Oct 30, 2025

View reviewed changes

hmstepanek and others added 2 commits October 30, 2025 13:58

Move inifinte tracing override to server side config

e024468

Add free-threaded Python to CI (#1562)

d16d5dc

hmstepanek force-pushed the partial-granularity-type-support branch from 1f241ed to d16d5dc Compare October 30, 2025 21:00

Merge branch 'main' into partial-granularity-type-support

9c14833

hmstepanek force-pushed the partial-granularity-type-support branch from 80d39d5 to 9c14833 Compare October 30, 2025 21:04

hmstepanek and others added 2 commits October 30, 2025 21:07

[MegaLinter] Apply linters fixes

db65db3

Trigger tests

7fd81a6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add support for partial granularity type #1532

Add support for partial granularity type #1532

Uh oh!

hmstepanek commented Oct 2, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 2, 2025 •

edited

Loading

Uh oh!

codecov-commenter commented Oct 2, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lrafeei Oct 29, 2025

Uh oh!

lrafeei Oct 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants


		application_settings.attribute_filter = AttributeFilter(flatten_settings(application_settings))

		simplify_distributed_tracing_sampler_granularity_settings(application_settings)

Add support for partial granularity type #1532

Are you sure you want to change the base?

Add support for partial granularity type #1532

Uh oh!

Conversation

hmstepanek commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Uh oh!

github-actions bot commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅MegaLinter analysis: Success

Uh oh!

codecov-commenter commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lrafeei Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

lrafeei Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

hmstepanek commented Oct 2, 2025 •

edited

Loading

github-actions bot commented Oct 2, 2025 •

edited

Loading

codecov-commenter commented Oct 2, 2025 •

edited

Loading