Skip to content

Conversation

@lrafeei
Copy link
Contributor

@lrafeei lrafeei commented Oct 3, 2025

Changing the *.max_samples_stored settings from event_harvest_config.harvest_limits.* in Python agent v11.0.0 resulted in the server side configurations not being properly applied to the agent, resulting in logs (and other events) being sent by the agent anyway.

This is not visible to users because the logging team has a block on this.

@github-actions
Copy link

github-actions bot commented Oct 3, 2025

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 7 0 0 0.95s
✅ MARKDOWN markdownlint 7 0 0 0 1.31s
✅ PYTHON ruff 946 0 0 0 1.03s
✅ PYTHON ruff-format 946 0 0 0 0.37s
✅ YAML prettier 15 0 0 0 1.5s
✅ YAML v8r 15 0 0 5.0s
✅ YAML yamllint 15 0 0 0.62s

See detailed reports in MegaLinter artifacts

MegaLinter is graciously provided by OX Security

@mergify mergify bot added the tests-failing Tests failing in CI. label Oct 3, 2025
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2025

Codecov Report

❌ Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.72%. Comparing base (68511db) to head (11fb973).

Files with missing lines Patch % Lines
newrelic/config.py 86.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1537      +/-   ##
==========================================
- Coverage   81.73%   81.72%   -0.02%     
==========================================
  Files         207      207              
  Lines       23899    23909      +10     
  Branches     3785     3789       +4     
==========================================
+ Hits        19535    19540       +5     
- Misses       3095     3098       +3     
- Partials     1269     1271       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lrafeei lrafeei marked this pull request as ready for review October 3, 2025 23:30
@lrafeei lrafeei requested a review from a team as a code owner October 3, 2025 23:30
@mergify mergify bot removed the tests-failing Tests failing in CI. label Oct 3, 2025
@mergify mergify bot added the tests-failing Tests failing in CI. label Oct 4, 2025
@lrafeei lrafeei requested a review from TimPansino October 6, 2025 17:37
@mergify mergify bot removed the tests-failing Tests failing in CI. label Oct 6, 2025
@lrafeei lrafeei merged commit 27f357c into main Oct 6, 2025
102 of 105 checks passed
@lrafeei lrafeei deleted the server-side-settings-sync branch October 6, 2025 19:51
@lrafeei lrafeei added this to the v11.1.0 milestone Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants