-
Notifications
You must be signed in to change notification settings - Fork 133
Python 3.14 Support #1540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.14 Support #1540
Conversation
✅MegaLinter analysis: Success
See detailed reports in MegaLinter artifacts |
|
Ignore the failing Python 3.14 benchmarks, that's because it's trying to compare results with the previous commit on |
a9012bf to
01c08dd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1540 +/- ##
==========================================
+ Coverage 81.62% 81.64% +0.01%
==========================================
Files 207 207
Lines 23913 23915 +2
Branches 3790 3791 +1
==========================================
+ Hits 19519 19525 +6
Misses 3122 3122
+ Partials 1272 1268 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8a64fb5 to
03be2b9
Compare
4a1be98 to
8b6c755
Compare
8b6c755 to
f0c31c6
Compare
b09926b to
9843100
Compare
9843100 to
b87aa07
Compare
hmstepanek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just had one question about whether we can remove that if always()-otherwise looks good!
|
|
||
| - name: Upload Results Artifacts | ||
| uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # 4.6.2 | ||
| if: always() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you even need this if here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just looked this up. Looks like it's used to still run even when canceled so I guess for that reason it makes sense to keep it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this is intended to always upload the artifacts if they exist so we capture failures and can summarize them.

Overview
asynciohooks for Python 3.14.tox.inias comments.toxtests totests.ymlworkflow.