Skip to content

Enable environment variables for attribute filters #1558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 3, 2025
+56 −22
Merged

Enable environment variables for attribute filters #1558

Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5e18810
Enable env vars for attribute filters
lrafeei Oct 28, 2025
adf8530
[MegaLinter] Apply linters fixes
lrafeei Oct 28, 2025
d28e2d2
Trigger tests
lrafeei Oct 28, 2025
b3158d7
Change attribute filters to space delimited
lrafeei Oct 29, 2025
2df2591
Merge branch 'main' into add-attributes-env-vars
mergify[bot] Oct 30, 2025
334a118
Merge branch 'main' into add-attributes-env-vars
mergify[bot] Nov 3, 2025
4679c39
Merge branch 'main' into add-attributes-env-vars
mergify[bot] Nov 3, 2025
a88f0d0
Merge branch 'main' into add-attributes-env-vars
mergify[bot] Nov 3, 2025
56c8a9b
Fix test assertion
TimPansino Nov 3, 2025
cfc413a
Merge branch 'main' into add-attributes-env-vars
mergify[bot] Nov 3, 2025
7c371b8
Merge branch 'main' into add-attributes-env-vars
TimPansino Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
105 changes: 84 additions & 21 deletions newrelic/core/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,6 +625,35 @@ def _environ_as_mapping(name, default=""):
return result


def _environ_as_comma_separated_list(name, default=""):
result = []
attributes = os.environ.get(name, default)

# Strip all whitespace and commas from the end of the string.
# That way, when we split a valid labels string by ',', the resulting
# list will contain no empty elements.

attributes = attributes.strip(", \t\n\r\f\v")

if not attributes:
return result

for attribute in attributes.split(","):
attribute = attribute.strip()

if attribute:
result.append(attribute)
else:
_logger.warning(
"Invalid configuration. Cannot parse: %r. Expected format 'attribute1, attribute2, attribute3'",
attributes,
)
result = []
break

return result


def _parse_status_codes(value, target):
items = value.split()
for item in items:
Expand Down Expand Up @@ -803,9 +832,9 @@ def default_otlp_host(host):
_settings.compressed_content_encoding = "gzip"
_settings.max_payload_size_in_bytes = 1000000

_settings.attributes.enabled = True
_settings.attributes.exclude = []
_settings.attributes.include = []
_settings.attributes.enabled = _environ_as_bool("NEW_RELIC_ATTRIBUTES_ENABLED", default=True)
_settings.attributes.exclude = _environ_as_comma_separated_list(os.environ.get("NEW_RELIC_ATTRIBUTES_EXCLUDE", ""))
_settings.attributes.include = _environ_as_comma_separated_list(os.environ.get("NEW_RELIC_ATTRIBUTES_INCLUDE", ""))

_settings.thread_profiler.enabled = True
_settings.cross_application_tracer.enabled = False
Expand All @@ -821,9 +850,15 @@ def default_otlp_host(host):
_settings.event_harvest_config.harvest_limits.analytic_event_data = _environ_as_int(
"NEW_RELIC_ANALYTICS_EVENTS_MAX_SAMPLES_STORED", default=DEFAULT_RESERVOIR_SIZE
)
_settings.transaction_events.attributes.enabled = True
_settings.transaction_events.attributes.exclude = []
_settings.transaction_events.attributes.include = []
_settings.transaction_events.attributes.enabled = _environ_as_bool(
"NEW_RELIC_TRANSACTION_EVENTS_ATTRIBUTES_ENABLED", default=True
)
_settings.transaction_events.attributes.exclude = _environ_as_comma_separated_list(
os.environ.get("NEW_RELIC_TRANSACTION_EVENTS_ATTRIBUTES_EXCLUDE", "")
)
_settings.transaction_events.attributes.include = _environ_as_comma_separated_list(
os.environ.get("NEW_RELIC_TRANSACTION_EVENTS_ATTRIBUTES_INCLUDE", "")
)

_settings.custom_insights_events.enabled = True
_settings.event_harvest_config.harvest_limits.custom_event_data = _environ_as_int(
Expand All @@ -847,13 +882,23 @@ def default_otlp_host(host):
_settings.event_harvest_config.harvest_limits.span_event_data = _environ_as_int(
"NEW_RELIC_SPAN_EVENTS_MAX_SAMPLES_STORED", default=SPAN_EVENT_RESERVOIR_SIZE
)
_settings.span_events.attributes.enabled = True
_settings.span_events.attributes.exclude = []
_settings.span_events.attributes.include = []
_settings.span_events.attributes.enabled = _environ_as_bool("NEW_RELIC_SPAN_EVENTS_ATTRIBUTES_ENABLED", default=True)
_settings.span_events.attributes.exclude = _environ_as_comma_separated_list(
os.environ.get("NEW_RELIC_SPAN_EVENTS_ATTRIBUTES_EXCLUDE", "")
)
_settings.span_events.attributes.include = _environ_as_comma_separated_list(
os.environ.get("NEW_RELIC_SPAN_EVENTS_ATTRIBUTES_INCLUDE", "")
)

_settings.transaction_segments.attributes.enabled = True
_settings.transaction_segments.attributes.exclude = []
_settings.transaction_segments.attributes.include = []
_settings.transaction_segments.attributes.enabled = _environ_as_bool(
"NEW_RELIC_TRANSACTION_SEGMENTS_ATTRIBUTES_ENABLED", default=True
)
_settings.transaction_segments.attributes.exclude = _environ_as_comma_separated_list(
os.environ.get("NEW_RELIC_TRANSACTION_SEGMENTS_ATTRIBUTES_EXCLUDE", "")
)
_settings.transaction_segments.attributes.include = _environ_as_comma_separated_list(
os.environ.get("NEW_RELIC_TRANSACTION_SEGMENTS_ATTRIBUTES_INCLUDE", "")
)

_settings.transaction_tracer.enabled = True
_settings.transaction_tracer.transaction_threshold = None
Expand All @@ -864,9 +909,15 @@ def default_otlp_host(host):
_settings.transaction_tracer.function_trace = []
_settings.transaction_tracer.generator_trace = []
_settings.transaction_tracer.top_n = 20
_settings.transaction_tracer.attributes.enabled = True
_settings.transaction_tracer.attributes.exclude = []
_settings.transaction_tracer.attributes.include = []
_settings.transaction_tracer.attributes.enabled = _environ_as_bool(
"NEW_RELIC_TRANSACTION_TRACER_ATTRIBUTES_ENABLED", default=True
)
_settings.transaction_tracer.attributes.exclude = _environ_as_comma_separated_list(
os.environ.get("NEW_RELIC_TRANSACTION_TRACER_ATTRIBUTES_EXCLUDE", "")
)
_settings.transaction_tracer.attributes.include = _environ_as_comma_separated_list(
os.environ.get("NEW_RELIC_TRANSACTION_TRACER_ATTRIBUTES_INCLUDE", "")
)

_settings.error_collector.enabled = True
_settings.error_collector.capture_events = True
Expand All @@ -879,9 +930,15 @@ def default_otlp_host(host):
)
_settings.error_collector.expected_status_codes = set()
_settings.error_collector._error_group_callback = None
_settings.error_collector.attributes.enabled = True
_settings.error_collector.attributes.exclude = []
_settings.error_collector.attributes.include = []
_settings.error_collector.attributes.enabled = _environ_as_bool(
"NEW_RELIC_ERROR_COLLECTOR_ATTRIBUTES_ENABLED", default=True
)
_settings.error_collector.attributes.exclude = _environ_as_comma_separated_list(
os.environ.get("NEW_RELIC_ERROR_COLLECTOR_ATTRIBUTES_EXCLUDE", "")
)
_settings.error_collector.attributes.include = _environ_as_comma_separated_list(
os.environ.get("NEW_RELIC_ERROR_COLLECTOR_ATTRIBUTES_INCLUDE", "")
)

_settings.browser_monitoring.enabled = True
_settings.browser_monitoring.auto_instrument = True
Expand All @@ -890,9 +947,15 @@ def default_otlp_host(host):
_settings.browser_monitoring.debug = False
_settings.browser_monitoring.ssl_for_http = None
_settings.browser_monitoring.content_type = ["text/html"]
_settings.browser_monitoring.attributes.enabled = False
_settings.browser_monitoring.attributes.exclude = []
_settings.browser_monitoring.attributes.include = []
_settings.browser_monitoring.attributes.enabled = _environ_as_bool(
"NEW_RELIC_BROWSER_MONITORING_ATTRIBUTES_ENABLED", default=False
)
_settings.browser_monitoring.attributes.exclude = _environ_as_comma_separated_list(
os.environ.get("NEW_RELIC_BROWSER_MONITORING_ATTRIBUTES_EXCLUDE", "")
)
_settings.browser_monitoring.attributes.include = _environ_as_comma_separated_list(
os.environ.get("NEW_RELIC_BROWSER_MONITORING_ATTRIBUTES_INCLUDE", "")
)

_settings.transaction_name.limit = None
_settings.transaction_name.naming_scheme = os.environ.get("NEW_RELIC_TRANSACTION_NAMING_SCHEME")
Expand Down
Loading