Skip to content

Refactor span_event & cache spans in compact mode#1615

Merged
hmstepanek merged 5 commits intodevelop-hybrid-core-tracingfrom
refactor-span-event
Dec 29, 2025
Merged

Refactor span_event & cache spans in compact mode#1615
hmstepanek merged 5 commits intodevelop-hybrid-core-tracingfrom
refactor-span-event

Conversation

@hmstepanek
Copy link
Contributor

@hmstepanek hmstepanek commented Dec 24, 2025

Overview

  • Refactor span_event function for the different modes into separate functions to improve readability and reduce complexity.
  • Cache spans before adding to reservoir in compact mode.

@hmstepanek hmstepanek requested a review from a team as a code owner December 24, 2025 00:16
@hmstepanek hmstepanek changed the base branch from main to develop-hybrid-core-tracing December 24, 2025 00:16
@github-actions
Copy link

github-actions bot commented Dec 24, 2025

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 7 0 0 0.84s
✅ MARKDOWN markdownlint 7 0 0 0 0.99s
✅ PYTHON ruff 972 0 0 0 0.97s
✅ PYTHON ruff-format 972 0 0 0 0.34s
✅ YAML prettier 15 0 0 0 1.44s
✅ YAML v8r 15 0 0 5.55s
✅ YAML yamllint 15 0 0 0.6s

See detailed reports in MegaLinter artifacts

MegaLinter is graciously provided by OX Security

@mergify mergify bot added the tests-failing Tests failing in CI. label Dec 24, 2025
@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2025

Codecov Report

❌ Patch coverage is 93.93939% with 6 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop-hybrid-core-tracing@0c05c66). Learn more about missing BASE report.

Files with missing lines Patch % Lines
newrelic/core/node_mixin.py 93.68% 2 Missing and 4 partials ⚠️
Additional details and impacted files
@@                      Coverage Diff                       @@
##             develop-hybrid-core-tracing    #1615   +/-   ##
==============================================================
  Coverage                               ?   79.93%           
==============================================================
  Files                                  ?      213           
  Lines                                  ?    25168           
  Branches                               ?     4001           
==============================================================
  Hits                                   ?    20117           
  Misses                                 ?     3622           
  Partials                               ?     1429           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hmstepanek hmstepanek changed the title Refactor span_event method Refactor span_event method & cache spans in compact mode Dec 24, 2025
@hmstepanek hmstepanek changed the title Refactor span_event method & cache spans in compact mode Refactor span_event & cache spans in compact mode Dec 24, 2025
@hmstepanek hmstepanek force-pushed the refactor-span-event branch 2 times, most recently from d31b281 to f3cf06a Compare December 24, 2025 01:01
@hmstepanek hmstepanek force-pushed the refactor-span-event branch 4 times, most recently from 3628fcd to 0dc442e Compare December 29, 2025 20:39
@hmstepanek hmstepanek merged commit 71cbb08 into develop-hybrid-core-tracing Dec 29, 2025
50 of 58 checks passed
@hmstepanek hmstepanek deleted the refactor-span-event branch December 29, 2025 20:57
@mergify mergify bot removed the tests-failing Tests failing in CI. label Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants