chore: Updated mysql tests to use MySQL 8.3 #2280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners-nr
commented
Jun 17, 2024
Comment on lines
+41
to
+42
| await runCommand(client, `FLUSH PRIVILEGES`) | ||
| await runCommand(client, `FLUSH TABLES`) |
There was a problem hiding this comment.
I don't think we really need these, but they certainly don't hurt.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2280 +/- ##
==========================================
- Coverage 96.27% 96.27% -0.01%
==========================================
Files 284 284
Lines 45230 45230
==========================================
- Hits 43544 43543 -1
- Misses 1686 1687 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mrickard
approved these changes
Jun 17, 2024
This was referenced Jul 20, 2024
This was referenced Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #2269.
We limit the Docker image to
mysql:8.3because in 8.4 they removed the configuration we need in order to make our tests work with themysqlnpm package. See