feat(subscribers): update pino subscriber to use native tracing channel (pino >= v9.10.0)#3871
Closed
andoan16 wants to merge 1 commit intonewrelic:mainfrom
Closed
Conversation
…9.10.0) Pino v9.10.0 added native instrumentation support via Node.js diagnostic channels using the tracing channel name `pino.logger`. We need to update our subscriber to detect the Pino version and use the native tracing channel when available (v9.10.0+), while falling back to the existing approach for older versions. The native channel provides events like `pino.logger.start` (before log write), `pino.logger.end` (after log write), and `pino.logger.error` (on error). The channel name format `pino.logger` differs from our internal convention, so we need to handle this specially. Affected files: index.js Signed-off-by: andoan16 <33853760+andoan16@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 New Feature
Problem
Pino v9.10.0 added native instrumentation support via Node.js diagnostic channels using the tracing channel name
pino.logger. We need to update our subscriber to detect the Pino version and use the native tracing channel when available (v9.10.0+), while falling back to the existing approach for older versions. The native channel provides events likepino.logger.start(before log write),pino.logger.end(after log write), andpino.logger.error(on error). The channel name formatpino.loggerdiffers from our internal convention, so we need to handle this specially.Severity:
highFile:
lib/subscribers/pino/index.jsSolution
Pino v9.10.0 added native instrumentation support via Node.js diagnostic channels using the tracing channel name
pino.logger. We need to update our subscriber to detect the Pino version and use the native tracing channel when available (v9.10.0+), while falling back to the existing approach for older versions. The native channel provides events likepino.logger.start(before log write),pino.logger.end(after log write), andpino.logger.error(on error). The channel name formatpino.loggerdiffers from our internal convention, so we need to handle this specially.Changes
lib/subscribers/pino/index.js(modified)Description
Please provide a brief description of the changes introduced in this pull request.
What problem does it solve? What is the context of this change?
How to Test
Please describe how you have tested these changes. Have you run the code against an example application?
What steps did you take to ensure that the changes are working correctly?
Related Issues
Please include any related issues or pull requests in this section, using the format
Closes #<issue number>orFixes #<issue number>if applicable.🤖 About this PR
This pull request was generated by ContribAI, an AI agent
that helps improve open source projects. The change was:
If you have questions or feedback about this PR, please comment below.
We appreciate your time reviewing this contribution!
Closes #3396