Skip to content

Fix kubelet-daemonset-windows's extraVolumeMounts when provided#1380

Open
zhangyuan wants to merge 2 commits intonewrelic:mainfrom
zhangyuan:fix-kubelet-daemonset-windows
Open

Fix kubelet-daemonset-windows's extraVolumeMounts when provided#1380
zhangyuan wants to merge 2 commits intonewrelic:mainfrom
zhangyuan:fix-kubelet-daemonset-windows

Conversation

@zhangyuan
Copy link
Copy Markdown

@zhangyuan zhangyuan commented Jan 21, 2026

Description

When extraVolumeMounts is provided, the current template renders $ instead of extraVolumeMounts (.) itself.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature / enhancement (non-breaking change which adds functionality)
  • Security fix
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Add changelog entry following the contributing guide
  • Documentation has been updated
  • This change requires changes in testing:
    • unit tests
    • E2E tests

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jan 21, 2026

CLA assistant check
All committers have signed the CLA.

@zhangyuan zhangyuan force-pushed the fix-kubelet-daemonset-windows branch from 28e05cd to 0f1e3da Compare January 21, 2026 09:41
@kondracek-nr kondracek-nr force-pushed the fix-kubelet-daemonset-windows branch from 0f1e3da to 8ab7770 Compare January 23, 2026 00:28
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.41%. Comparing base (e3ef7d1) to head (8ab7770).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1380   +/-   ##
=======================================
  Coverage   74.41%   74.41%           
=======================================
  Files          53       53           
  Lines        3666     3666           
=======================================
  Hits         2728     2728           
  Misses        766      766           
  Partials      172      172           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants