feat: Collect CRD metrics from kube-state-metrics as dimensional metrics#1390
Open
feat: Collect CRD metrics from kube-state-metrics as dimensional metrics#1390
Conversation
Resolved conflicts: - go.sum: Accepted main branch dependency versions (ginkgo v2.27.2, gomega v1.38.2)
Run go mod tidy to include newrelic-telemetry-sdk-go and update to latest ginkgo/gomega versions
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1390 +/- ##
==========================================
+ Coverage 74.41% 75.00% +0.58%
==========================================
Files 53 54 +1
Lines 3666 3788 +122
==========================================
+ Hits 2728 2841 +113
- Misses 766 771 +5
- Partials 172 176 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for collecting Custom Resource Definition (CRD) metrics from kube-state-metrics as dimensional metrics sent to the New Relic Metric API.
Key Features:
ksm.enableCustomResourceMetricsconfig enables collection of allkube_customresource_*metrics from KSMksm.harvestPeriodconfig allows batching metrics before sending (defaults to scrape interval for consistency)ksm.metricAPIURLconfig supports proxies or alternative endpointsConfiguration Example:
Testing:
See COMPREHENSIVE_TEST_REPORT.md for detailed test results.
Type of change
[] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] New feature / enhancement (non-breaking change which adds functionality)
[] Security fix
[] Bug fix (non-breaking change which fixes an issue)
Checklist:
[x] Add changelog entry following the https://github.com/newrelic/nri-kubernetes/blob/main/CONTRIBUTING.md#pull-requests
[x]Documentation has been updated