feat: add privileged mode for Windows node monitoring#1409
Draft
kondracek-nr wants to merge 9 commits intomainfrom
Draft
feat: add privileged mode for Windows node monitoring#1409kondracek-nr wants to merge 9 commits intomainfrom
kondracek-nr wants to merge 9 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1409 +/- ##
=======================================
Coverage 75.01% 75.01%
=======================================
Files 53 53
Lines 3706 3706
=======================================
Hits 2780 2780
Misses 753 753
Partials 173 173 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kondracek-nr
force-pushed
the
kondracek/win-hp-noprocess
branch
from
bd06165 to
43b8d99
Compare
kondracek-nr
changed the title
kondracek-nr
force-pushed
the
kondracek/win-hp-noprocess
branch
2 times, most recently
from
88cfb3d to
b0d4fcb
Compare
kondracek-nr
force-pushed
the
kondracek/win-hp-noprocess
branch
4 times, most recently
from
5d6e8b9 to
9519aee
Compare
kondracek-nr
force-pushed
the
kondracek/win-hp-noprocess
branch
from
9519aee to
a6af1fe
Compare
chore: use container sandbox path when in privileged mode chore: add tests for hostprocess & privileged support in windows chore: allow overriding privilged for windows
kondracek-nr
force-pushed
the
kondracek/win-hp-noprocess
branch
from
2ccdd03 to
deae9cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change adds privileged mode (false by default and set separately from linux privileged mode) to Windows node monitoring. This mode enables deeper host monitoring apart from what is reported by Kubernetes, and will populate the host's infrastructure metrics dashboard.
Please note that at this time,
ProcessSamplemetrics are strictly limited to agent container's processes and do not include host process metrics.Why set separately?
We've added this mode as a separate lever because companies may have different security postures for their Linux and Windows machines. Because privileged Windows containers run as HostProcess pods with direct access to the host machine, a company may be ok running their Linux pods in privileged mode, but not their Windows pods.
Type of change
Checklist: