Skip to content

remove unnecessary factory function wrappers#1429

Open
jamescripter wants to merge 3 commits intomainfrom
remove-unnecessary-factory-function-wrappers
Open

remove unnecessary factory function wrappers#1429
jamescripter wants to merge 3 commits intomainfrom
remove-unnecessary-factory-function-wrappers

Conversation

@jamescripter
Copy link
Copy Markdown
Contributor

@jamescripter jamescripter commented Mar 5, 2026

Description

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature / enhancement (non-breaking change which adds functionality)
  • Security fix
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Add changelog entry following the contributing guide
  • Documentation has been updated
  • This change requires changes in testing:
    • unit tests
    • E2E tests

@jamescripter jamescripter requested a review from a team as a code owner March 5, 2026 17:52
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 5, 2026

Codecov Report

❌ Patch coverage is 73.33333% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.68%. Comparing base (47215db) to head (63bcb37).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ksm/metric/metric.go 73.33% 4 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1429      +/-   ##
==========================================
- Coverage   74.70%   74.68%   -0.02%     
==========================================
  Files          53       53              
  Lines        3688     3686       -2     
==========================================
- Hits         2755     2753       -2     
  Misses        762      762              
  Partials      171      171              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant