feat: introduce container-level resource setting#1436
Open
kondracek-nr wants to merge 1 commit intomainfrom
Open
feat: introduce container-level resource setting#1436kondracek-nr wants to merge 1 commit intomainfrom
kondracek-nr wants to merge 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1436 +/- ##
=======================================
Coverage 75.01% 75.01%
=======================================
Files 53 53
Lines 3706 3706
=======================================
Hits 2780 2780
Misses 753 753
Partials 173 173 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
749f2ef to
2ad7247
Compare
2ad7247 to
8d84bdf
Compare
8d84bdf to
84a9ea5
Compare
Philip-R-Beckwith
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change introduces container-level resource-setting to the kubelet & controlplane components. The ksm component already has container-level resource-setting & this change follows the pattern set by ksm. For now, we will continue to accommodate applying resource values set at the
kubelet.resources/controlplane.resourceslevel to each container.If
kubelet.resourcesis set, the assumption is that the user is still using this config path & isn't aware of container-level resource setting, so an explicit setting at this level is prioritized over the default container-level settings this change introduces. We print a warning message that the behavior of that config path will be changing in the future for pod-level resource setting & to use the container-level config paths.The reason for this change is as follows:
kubelet.resources/controlplane.resourcesin the future to accommodate pod-level resource setting for our customers.Type of change
Checklist: