Merged
Conversation
danielgblanco
previously approved these changes
Mar 16, 2026
Author
|
@danielgblanco I made some updates. I'm not sure if we'll ever get to a perfect combo of included vs. excluded dimensions without some deeper analysis. I wish I had time to sift through it all, but I don't. I'm not concerned about cardinality explosions in the context of the demo. I removed the |
danielgblanco
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Updating the
nr-k8s-otel-collector-deploymentconfig to includespanmetricsfor Astroshop services that do not publish metrics by default. This includes:Because NRDOT is not shipped with the
spanmetricsconnector, we must use the OTel contrib image in thenr-k8s-otel-collector-deploymentinstance.