Skip to content

[feat] add spanmetrics#160

Merged
bpschmitt merged 3 commits intonewrelic:mainfrom
bpschmitt:add-spanmetrics
Mar 17, 2026
Merged

[feat] add spanmetrics#160
bpschmitt merged 3 commits intonewrelic:mainfrom
bpschmitt:add-spanmetrics

Conversation

@bpschmitt
Copy link

@bpschmitt bpschmitt commented Mar 16, 2026

Changes

Updating the nr-k8s-otel-collector-deployment config to include spanmetrics for Astroshop services that do not publish metrics by default. This includes:

  • currency
  • quote
  • payment
  • product-reviews
  • recommendation

Because NRDOT is not shipped with the spanmetrics connector, we must use the OTel contrib image in the nr-k8s-otel-collector-deployment instance.

@bpschmitt bpschmitt changed the title [feat] add spanmetrics patch [feat] add spanmetrics Mar 16, 2026
@bpschmitt bpschmitt requested a review from danielgblanco March 16, 2026 15:22
danielgblanco
danielgblanco previously approved these changes Mar 16, 2026
@bpschmitt
Copy link
Author

@danielgblanco I made some updates. I'm not sure if we'll ever get to a perfect combo of included vs. excluded dimensions without some deeper analysis. I wish I had time to sift through it all, but I don't. I'm not concerned about cardinality explosions in the context of the demo.

I removed the set_semconv_span_name() transformation as it was setting the span name to a generic otel value. I don't think the original values were high-cardinality to begin with, though, i could see this being valuable in a production environment.

@bpschmitt bpschmitt merged commit fecaeef into newrelic:main Mar 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants