Skip to content

feat/TMR-2874-Allow-mui-icons#944

Open
KayKostadinov wants to merge 1 commit intomainfrom
feat/TMR-2874-Allow-mui-icons
Open

feat/TMR-2874-Allow-mui-icons#944
KayKostadinov wants to merge 1 commit intomainfrom
feat/TMR-2874-Allow-mui-icons

Conversation

@KayKostadinov
Copy link
Copy Markdown
Contributor

Jira- TMR-2874

What
Extend the interface of toNewskitIcon function to allow 3rd party icon libraries

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@KayKostadinov KayKostadinov requested a review from a team as a code owner November 25, 2025 16:20
@github-actions github-actions bot added the feature This change contains a new feature label Nov 25, 2025
@KayKostadinov KayKostadinov added the blocked This change is blocked label Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked This change is blocked feature This change contains a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant