Don't use HTTP_REFERER for Dummy_Request to prevent (logged) exceptions.

[possi]

Scenario to create an Invalid Dummy-Request-Url (which throws an exception in Debug-Mode):
0. Assume a global, public ESI-Block on page (e.g. "menu")

1. Search for "" (without quotes) -> /catalogsearch/result/?q=\
2. Click any page
3. "Invalid URI supplied"-Zend_Uri_Exception is thrown

Disabling the debug mode suppresses the exception, but spams the logs.

Reason:
For global blocks no /r64/.../-Param is passed to the ESI-Url. Mage_Core_Controller_Varien_Action::_getRefererUrl() uses $_SERVER['HTTP_REFERER'] if no r64-Param is in the Url. This Http-Header is never filtered, and the \ within the Url isn't allowed by Zend_Uri_http::validateQuery()s regexp.

Solution:
There is no reason to use the referrer as the Dummy_Request for global blocks, as they shouldn't rely on any url other than the front-page. If else, they currently wouldn't function either, as the referrer-url contains a different url then the page the user is currently visiting.

[miguelbalparda]

Have you seen #1235? It seems to be pretty similar to this, thoughts?

[possi]

Indeed. But my approach fixes the root-cause instead of just silently catch the exception.

[miguelbalparda]

@magedev thoughts?

[jeroenvermeulen]

Looks good (did not test)