Fix wrong skin, template, locale in ESI blocks#1538
Open
felixbuenemann wants to merge 1 commit intonexcess:develfrom
Open
Fix wrong skin, template, locale in ESI blocks#1538felixbuenemann wants to merge 1 commit intonexcess:develfrom
felixbuenemann wants to merge 1 commit intonexcess:develfrom
Conversation
if they differ from the layout name.
Author
|
I've run this patch in production with Magento 1.9.3.9 and Turpentine 0.7.5 for about a week without problems. |
|
Thx @felixbuenemann for this PR. We had an issue with the wrong skin in ESI block and it fixes it. |
Contributor
|
Tired of waiting for @nexcess |
Author
|
@jeroenvermeulen Thanks for taking over, it looks like the main repo is pretty much unmaintained for some time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug were the wrong skin, template or locale is used when rendering ESI blocks and either of those values differs from the layout name.
One problem this fixes is wrong skin URLs, if the skin name differs from the layout name, which was previously fixed in #972, but later reverted in #1164.
The new fix passes the current layout, skin, template and locale as part of the ESI data, instead of only the layout.
See #1164 for the discussion and #971 for the original bug report regarding wrong skin URLs.