Skip to content

Conversation

@deepInTheWoodz
Copy link
Contributor

๐Ÿ“Œ PR ๊ฐœ์š”

  • ์—”ํ‹ฐํ‹ฐ, DTO, Enum ๊ด€๋ จ ๋ฆฌํŒฉํ† ๋ง์„ ํ†ตํ•ด ํ”„๋กœ์ ํŠธ ์ „๋ฐ˜์˜ ์ผ๊ด€์„ฑ๊ณผ ์œ ์ง€๋ณด์ˆ˜์„ฑ์„ ๊ฐœ์„ ํ•˜์˜€์Šต๋‹ˆ๋‹ค.

๐Ÿ” ๋ณ€๊ฒฝ ์‚ฌํ•ญ

  • BaseEntity ์ƒ์†์„ ํ™œ์šฉํ•˜์—ฌ ์ค‘๋ณต๋œ @EntityListeners ์ œ๊ฑฐ
  • DTO ํด๋ž˜์Šค๋“ค์„ record ๊ธฐ๋ฐ˜์œผ๋กœ ๋ณ€๊ฒฝํ•˜์—ฌ ๋ถˆ๋ณ€์„ฑ๊ณผ ์ฝ”๋“œ ๊ฐ„๊ฒฐ์„ฑ ํ™•๋ณด
  • MatchStatus.CANCELLED โ†’ CANCELED ๋กœ ๋ช…์นญ ์ˆ˜์ • (ํ”„๋ก ํŠธ์—”๋“œ์™€ ์šฉ์–ด ํ†ต์ผ)

๐Ÿงช ํ…Œ์ŠคํŠธ ๋ฐฉ๋ฒ•

  1. ์—”ํ‹ฐํ‹ฐ ์ €์žฅ/์ˆ˜์ • ์‹œ Auditing ๊ธฐ๋Šฅ์ด ๊ธฐ์กด๊ณผ ๋™์ผํ•˜๊ฒŒ ๋™์ž‘ํ•˜๋Š”์ง€ ํ™•์ธ
  2. DTO ์ง๋ ฌํ™”/์—ญ์ง๋ ฌํ™” ๊ณผ์ •์ด ์ •์ƒ์ ์œผ๋กœ ์ˆ˜ํ–‰๋˜๋Š”์ง€ ํ™•์ธ
  3. ํด๋ผ์ด์–ธํŠธ ์ธก์—์„œ CANCELED ์ƒํƒœ๊ฐ’์„ ์ •์ƒ์ ์œผ๋กœ ์ˆ˜์‹ /์ฒ˜๋ฆฌํ•˜๋Š”์ง€ ํ™•์ธ

โœ… ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•จ
  • ๊ธฐ์กด ๊ธฐ๋Šฅ์— ๋ฌธ์ œ๊ฐ€ ์—†์Œ
  • ์ฝ”๋“œ ์ปจ๋ฒค์…˜(Prettier/ESLint, Checkstyle ๋“ฑ)์„ ํ†ต๊ณผํ•จ
  • ํ•„์š” ์‹œ ๋ฌธ์„œ ์—…๋ฐ์ดํŠธ ์™„๋ฃŒ
  • ๊ด€๋ จ ์ด์Šˆ์— ์—ฐ๊ฒฐํ•จ

๐Ÿ“Ž ์ฐธ๊ณ  ์ด์Šˆ

Ref: #78

@hyeminleeee hyeminleeee merged commit 2d1183f into develop Aug 18, 2025
1 check passed
@hyeminleeee hyeminleeee deleted the feature/78-refactoring branch August 18, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants