[pull] master from moby:master #1404
Open
+1,744,895
−626,871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akihiro Suda <[email protected]>
Signed-off-by: Akihiro Suda <[email protected]>
api, client: add separate LICENSE file
NRI: add daemon.json/command line options
Signed-off-by: Rob Murray <[email protected]>
Signed-off-by: Rob Murray <[email protected]>
Signed-off-by: Rob Murray <[email protected]>
NRI: import and instantiate containerd's NRI adaptation package
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Make sure the error is the one we expected, and slightly clarify the behavior (named volumes not having a meaning in VOLUME, so will be used as-is). Signed-off-by: Sebastiaan van Stijn <[email protected]>
These tests used intermediate images (as produced by the classic builder) as part of the test. When using BuildKit, such images are not produced, and will only be in the build-cache. From the tests, it looks like the extra checks were not critical to verify the behavior, so let's simplify them to not depend on this. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Use the GRPC server when requests are for the grpc content type. Signed-off-by: Derek McGowan <[email protected]>
Re-use some of the reflection results where possible. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Use generics so that the produced output is already in the right type. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Commit 6aea8c2 updated this part of the test to account for BuildKit now being used as default, which doesn't use regular containers to "commit" to an image, and therefore doesn't produce events as part of the build. However, it changed it to filter for `build` type events, which .. don't exist. The test passed because it only checked for number of events produced, which is approximated by checking the number of lines in the output. In this case, the output would be empty, so "events" was a slice of strings with length 1; an empty string. Given that BuildKit doesn't produce meaningful events to test for, we could either disable BuildKit, to test the legacy builder, or just remove this part of the test. Let's do the latter. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Image create events were added in API 1.46, and filtered out in older API versions. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
libnetwork/options: GenerateFromModel: less reflection, and use generics
integration: increase timeout; gha/vm: update Lima to v2.0.2
Signed-off-by: Rob Murray <[email protected]>
Signed-off-by: Rob Murray <[email protected]>
assorted test-changes in preparation of updating integration-cli CLI version
NRI: allow plugins to see/modify env vars
Address some post-merge review comments. Signed-off-by: Rob Murray <[email protected]>
NRI: minor cleanups
…ut-kill docs: document healthcheck timeout termination behavior
daemon: minor cleanup and linting fixes
Signed-off-by: gsotelo <[email protected]>
client: use stop function to deregister context.AfterFunc
docs: fix reversed descriptions of version.Arch and info.Architecture
integration/container: TestStats: explicitly check zero-value
docs: fix typo in IPv6 constant comment
…roups-v2 docs: update stats API description for cgroups v2 compatibility
When attempting to read a (malformed) resolv.conf with a very long line,
a obscure error would be produced that didn't provide much context to
identify the problem;
Handler for POST /v1.51/containers/mariadb11/start returned error: bufio.Scanner: token too long
This patch adds some additional error-handling to detect this situation,
and includes the filename of the resolv.conf to help the user locating
the file that failed to be parsed.
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Minor enhancement / follow-up to c8aaeea; make sure we never attempt to find `go.mod` files in other locations. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
libnet/internal/resolvconf: Parse: improve error message
…cription docs: improve description of image tag API endpoint
…4-description docs: fix base64 encoding description for secrets and configs
- rename vars that shadowed - suppress some unhandled errors Signed-off-by: Sebastiaan van Stijn <[email protected]>
This syncs the versioned swagger files with some fixes and enhancements made in: - 955897f - 22345e3 - 917d66d - 1fd2395 Signed-off-by: Sebastiaan van Stijn <[email protected]>
The http.Client passed into client.WithHTTPClient() is modified by the constructor in-place: the value of its Transport field is mutated and wrapped in an OpenTelemetry decorator. This can lead to very surprising behaviour when a second client is constructed reusing the same http.Client value. If the http.Client is configured for TLS, the second client will fail to detect that and will incorrectly dial the Engine API socket as cleartext HTTP. Copy the provided http.Client so our modifications don't leak out to unexpected places. Signed-off-by: Cory Snider <[email protected]>
vendor: cloud.google.com/go/logging v1.13.1
client: do not modify user-provided HTTP client
api/docs: backport assorted fixes and enhancements to older api versions
hack/validate: only search repo-dir for modules
migrate TestAPIOptionsRoute to integration test
Hash the container ID, mount source and destination together to form a layer name. This ensures the generated names are filesystem-friendly and don't exceed path length limits while maintaining uniqueness across different mount points and containers. Signed-off-by: Paweł Gronowski <[email protected]>
Can happen for `docker run --network none ...` Signed-off-by: Paweł Gronowski <[email protected]>
daemon/volumes: More fs friendly image mount layer names
daemon/libnetwork: Fix panic in findHNSEp when IP networks are nil
internal/testutil/daemon: fix minor linting issues
api: add root doc.go to prevent fallback to github.com/moby/moby
This test was testing the /_ping endpoint, which is intercepted by the default MockClient. Signed-off-by: Sebastiaan van Stijn <[email protected]>
client: fix TestWithUserAgent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )