Open
Conversation
hyunniiii
requested changes
Dec 28, 2022
hyunniiii
left a comment
hyunniiii
left a comment
There was a problem hiding this comment.
안녕하세요 민성님~
몇가지 코멘트 남겼으니 확인 부탁드립니다 :)
Comment on lines
+23
to
+35
| companion object | ||
| } | ||
|
|
||
| fun Calculator.Companion.from(input: String): Calculator { | ||
| return Calculator(Inputs.from(extractInputs(input))) | ||
| } | ||
|
|
||
| private fun extractInputs(input: String): List<CalculatorInput> { | ||
| return input.split(" ").asSequence() | ||
| .filter { it.isNotBlank() } | ||
| .map { CalculatorInput.from(it) } | ||
| .toList(); | ||
| } |
There was a problem hiding this comment.
Suggested change
| companion object | |
| } | |
| fun Calculator.Companion.from(input: String): Calculator { | |
| return Calculator(Inputs.from(extractInputs(input))) | |
| } | |
| private fun extractInputs(input: String): List<CalculatorInput> { | |
| return input.split(" ").asSequence() | |
| .filter { it.isNotBlank() } | |
| .map { CalculatorInput.from(it) } | |
| .toList(); | |
| } | |
| companion object { | |
| fun from(input: String): Calculator { | |
| return Calculator(Inputs.from(extractInputs(input))) | |
| } | |
| private fun extractInputs(input: String): List<CalculatorInput> { | |
| return input.split(" ").asSequence() | |
| .filter { it.isNotBlank() } | |
| .map { CalculatorInput.from(it) } | |
| .toList(); | |
| } | |
| } |
https://pearlluck.tistory.com/722
companion object는 이렇게 사용하시면 될 것 같습니다 :)
Comment on lines
+14
to
+17
| val hasNextNumber: Boolean | ||
| get() { | ||
| return numbers.size > numbersPosition | ||
| } |
There was a problem hiding this comment.
Suggested change
| val hasNextNumber: Boolean | |
| get() { | |
| return numbers.size > numbersPosition | |
| } | |
| val hasNextNumber: Boolean | |
| get() = numbers.size > numbersPosition |
이렇게 하면 조금 더 깔끔해질 것 같아요!
Comment on lines
+44
to
+53
| fun Inputs.Companion.from(values: List<CalculatorInput>): Inputs { | ||
| values.validateFormat() | ||
|
|
||
| val groupBy = values.groupBy { it.getType() } | ||
|
|
||
| return Inputs( | ||
| groupBy[Number::class.java] as List<Number>, | ||
| groupBy[Operation::class.java] as List<Operation> | ||
| ) | ||
| } |
There was a problem hiding this comment.
이 부분도 이 코멘트 처럼 companion object 부분을 수정해주세요 :)
Comment on lines
+64
to
+66
| if (this[i] !is Number) { | ||
| throw IllegalArgumentException("인풋 포멧 오류") | ||
| } |
There was a problem hiding this comment.
kotlin 의 require을 사용해보는건 어떨까요?
https://seosh817.tistory.com/155
또한 어떤 에러인지 알 수 있도록 에러 메시지를 조금 더 상세하게 작성해주세요!
Comment on lines
+94
to
+104
| private fun CalculatorInput.getType(): Class<out CalculatorInput> { | ||
| if (this is Number) { | ||
| return Number::class.java | ||
| } | ||
|
|
||
| if (this is Operation) { | ||
| return Operation::class.java | ||
| } | ||
|
|
||
| throw IllegalArgumentException("잘못된 타입") | ||
| } |
There was a problem hiding this comment.
when을 사용하면 조금 더 간결하게 표현할 수 있을 것 같아요!
Comment on lines
+7
to
+13
| fun CalculatorInput.Companion.from(input: String): CalculatorInput { | ||
| return when { | ||
| input.isTypeOf(Number::class.java) -> Number(input.toInt()) | ||
| input.isTypeOf(Operation::class.java) -> Operation.from(input) | ||
| else -> throw IllegalArgumentException("알 수 없는 입력값.") | ||
| } | ||
| } |
|
코틀린의 장점 중 하나가 가독성이라고 생각합니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
안녕하세요~ 드디어 시작합니다!!
첫 pr이다보니, 일단은 코드에 대한 평가를 먼저 받고 싶어요.
코틀린으로 처음 코딩해보니 어렵네요.. 아직까지는 자바가 너무 편하기도 하고요...
step1, step2를 함께 진행했습니다.
몇가지 궁금한 부분은...
companion을 이런식으로 사용하는게 좋은지 모르겠어요. 정적 팩터리 메소드를 구현하기 위해서 쓰기는 했는데. 이렇게 막 사용해도 되는 키워드인가요??
SAM을 사용하면 좋은점이 무엇인가요?? 가독성..? 은 크게 체감이 안되고.. 코틀린은 왜 SAM을 채택했을까요?
리뷰 부탁 드립니다! 감사합니다~