fix(qwik): don't build server deps on client#12723
fix(qwik): don't build server deps on client#12723ThangHuuVu merged 2 commits intonextauthjs:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
@wmertens is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
|
Any chance of a review? It's a small change and it prevents people from using @authjs/qwik with vite 6 |
|
This is blocking QwikDev/qwik#7382 |
|
@ThangHuuVu @balazsorban44 if you have a couple of minutes to review 🙏 . Ideally we'd like to upgrade to vite 6, but we want to make sure those using auth js continue to have a seamless experience 🙂 |
|
@thejackshelton, thank you for following up. Since Vite is the foundation for many projects, can you please follow this PR again to speed up its merging? |
The optimizer doesn't fully remove server imports and it helps to put `isServer` guards so server-side modules are not bundled for the client
|
@ThangHuuVu is there any chance of you hitting the approve button so the workflow can run? |
ThangHuuVu
left a comment
There was a problem hiding this comment.
Thanks, sorry for the delay, I'll cut a release this weekend.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12723 +/- ##
=======================================
Coverage 39.19% 39.19%
=======================================
Files 200 200
Lines 31606 31606
Branches 1374 1380 +6
=======================================
Hits 12388 12388
Misses 19218 19218 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thank you guys. Special thanks to @wmertens. Our team migrated to Vite 6 without a bug. |
☕️ Reasoning
Put some
isServerguards so @auth/core is not bundled for the client, since that breaks the build with Vite 6.The culprit is the environment configuration.
🧢 Checklist
🎫 Affected issues
none created
📌 Resources