-
Notifications
You must be signed in to change notification settings - Fork 5
fix: add allowCreateNew to filepicker #2070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2070 +/- ##
==========================================
- Coverage 46.38% 45.85% -0.54%
==========================================
Files 15 15
Lines 429 434 +5
Branches 82 83 +1
==========================================
Hits 199 199
- Misses 202 207 +5
Partials 28 28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| path?: string | ||
| }>(), { | ||
| allowPickDirectory: false, | ||
| allowCreateNew: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it feels like this default would be better off to be true but allowPickDirectory has a default of false and they maybe should be consistent?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just use noMenu with default false
|
I think it would be good to call the pop |
Signed-off-by: grnd-alt <[email protected]>
3dc0665 to
af199ae
Compare
resolves #1893
required for: nextcloud/server#54234